-
Notifications
You must be signed in to change notification settings - Fork 19
Description
We have topostats.tracing.dnacurvature sub-module lingering around without being used.
The code isn't used anywhere so its possible we could remove it.
From Slack chat...
I think it was probably Jeans old code - is that right Sylvia? In that case I’m pretty sure it can go but it would be nice to ask max too if we can
@SyllviaWhittle
It uses the derivatives method for curvature. Mathematically more proper but produces very varying results in my experience, since it’s mathematical formulae and expect points that are pretty continuous (small angle changes) and evenly spaced, which is often an unreasonable expectation.
There’s not much code there, two functions and a class.
I’d say remove, since I don’t see this method being robust to our data, but I could easily be wrong. This is just what
I recall from trying similar.
Looking at the "blame" it look like @ns-rse refactored the code at some point.
@ns-rse ... if its not being used there is no harm in removing it, it will remain in the history of the repository and
could be recovered if needed in the future.