From ec8a682e6f2bdbc234aed650caade6ce02afc3db Mon Sep 17 00:00:00 2001 From: Piotr Konopka Date: Fri, 24 Jan 2025 17:18:18 +0100 Subject: [PATCH] [core] fix nil task access Fixes nil access issue introduced by myself in https://github.com/AliceO2Group/Control/pull/647 --- core/task/manager.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/core/task/manager.go b/core/task/manager.go index 6e65a1cf..de705fe2 100644 --- a/core/task/manager.go +++ b/core/task/manager.go @@ -953,11 +953,13 @@ func (m *Manager) GetTask(id string) *Task { func (m *Manager) updateTaskState(taskId string, state string) { taskPtr := m.roster.getByTaskId(taskId) - if taskPtr == nil && state != "DONE" { - log.WithField("taskId", taskId). - WithField("state", state). - WithField(infologger.Level, infologger.IL_Support). - Warn("attempted state update of task not in roster") + if taskPtr == nil { + if state != "DONE" { + log.WithField("taskId", taskId). + WithField("state", state). + WithField(infologger.Level, infologger.IL_Support). + Warn("attempted state update of task not in roster") + } return }