-
Notifications
You must be signed in to change notification settings - Fork 35
Description
Hello @TheAssassin !
I've encountered a weird issue while using AppImageLauncher.
For desktop entries with X-AppImage-Version=1.0.0 the version is, for some reason, not appended to the name when app is being integrated.
[Desktop Entry]
Type=Application
Name=T.Nebula
Icon=t-chan-favicon
Exec=t.nebula-linux
Comment=T.Nebula: Client Downloader
X-AppImage-Version=2.3.2
Categories=Utility;
Will create a desktop entry with just T.Nebula
While this:
[Desktop Entry]
Type=Application
Name=T.Nebula
Icon=tassta-chan-favicon
Exec=t.nebula-linux
Comment=T.Nebula: TASSTA MCX Client Downloader
X-AppImage-Version=2.3.2-test
Categories=Utility;
Will result in T.Nebula (2.3.2-test)
I've been searching through the source code to find where the substitution takes place and tracked it down to this class:
src/libappimage/desktop_integration/integrator/DesktopEntryEditor.cpp, and this method
libappimage/src/libappimage/desktop_integration/integrator/DesktopEntryEditor.cpp
Line 56 in e56c21b
| void DesktopEntryEditor::appendVersionToName(XdgUtils::DesktopEntry::DesktopEntry& desktopEntry) { |
Unfortunalety, I have next to zero c++ expertise to debug this myself.
My guess would be that, for some reason, this
libappimage/src/libappimage/desktop_integration/integrator/DesktopEntryEditor.cpp
Line 75 in e56c21b
| if (name.find(appImageVersion) != std::string::npos) |
might be operating wrong.
Anyway, please let me know if any additional context or information is requied.