-
-
Notifications
You must be signed in to change notification settings - Fork 67
Open
Description
The pan gesture used to open the sidebar overrides most other gestures in the content view that it targets, and doesn't mark itself as "failed" when it decides to ignore a certain gesture. This makes it very hard to use other gestures in this view. When implementing a custom gesture some success can be achieved by being creative with ShouldBeRequiredToFailBy... and the likes, but when you do not have control over the other gesture recognizer (my concrete example: a swipe left to start UITableViewCell editing mode) you're basically left without options.
The solution would be to
- Make the pan gesture fail appropriately (can be as simple as returning
falsefromSlideoutPanDelegate.ShouldReceiveTouch()when the touch is not inside the gesture active area) and / or - Allow access to the gesture recognizer so a custom delegate can be used.
Sidebar.PanGestureis public, but because the actual_sidebaris a private property of theSidebarControllerit can currently only be accessed with reflection (which is what I'm doing to work around the problem right now).
I'd be willing to submit a PR for one or both of these changes if this sounds reasonable to you.
Metadata
Metadata
Assignees
Labels
No labels