From 07420d494031875bf70f8d9297823a59ebac8e0d Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Thu, 28 Jun 2018 01:00:52 +0100 Subject: [PATCH 1/8] Create .travis-ci.sh --- .travis-ci.sh | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 .travis-ci.sh diff --git a/.travis-ci.sh b/.travis-ci.sh new file mode 100644 index 0000000..c3fc4d3 --- /dev/null +++ b/.travis-ci.sh @@ -0,0 +1,84 @@ +#!/bin/bash + +# This script is triggered from the script section of .travis.yml +# It runs the appropriate commands depending on the task requested. + +set -e + +CPP_LINT_URL="https://raw.githubusercontent.com/google/styleguide/gh-pages/cpplint/cpplint.py"; + +SPELLINGBLACKLIST=$(cat <<-BLACKLIST + -wholename "./.git/*" +BLACKLIST +) + +if [[ $TASK = 'lint' ]]; then + # run the lint tool only if it is the requested task + # first check we've not got any generic NOLINTs + # count the number of generic NOLINTs + nolints=$(grep -IR NOLINT * | grep -v "NOLINT(" | wc -l) + if [[ $nolints -ne 0 ]]; then + # print the output for info + echo $(grep -IR NOLINT * | grep -v "NOLINT(") + echo "Found $nolints generic NOLINTs" + exit 1; + else + echo "Found $nolints generic NOLINTs" + fi; + # then fetch and run the main cpplint tool + wget -O cpplint.py $CPP_LINT_URL; + chmod u+x cpplint.py; + ./cpplint.py \ + --filter=-legal/copyright,-readability/streams,-runtime/arrays \ + $(find ./ \( -name "*.h" -or -name "*.cpp" \) | xargs) + if [[ $? -ne 0 ]]; then + exit 1; + fi; +elif [[ $TASK = 'spellintian' ]]; then + # run spellintian only if it is the requested task, ignoring duplicate words + spellingfiles=$(eval "find ./ -type f -and ! \( \ + $SPELLINGBLACKLIST \ + \) | xargs") + # count the number of spellintian errors, ignoring duplicate words + spellingerrors=$(zrun spellintian $spellingfiles 2>&1 | grep -v "\(duplicate word\)" | wc -l) + if [[ $spellingerrors -ne 0 ]]; then + # print the output for info + zrun spellintian $spellingfiles | grep -v "\(duplicate word\)" + echo "Found $spellingerrors spelling errors via spellintian, ignoring duplicates" + exit 1; + else + echo "Found $spellingerrors spelling errors via spellintian, ignoring duplicates" + fi; +elif [[ $TASK = 'spellintian-duplicates' ]]; then + # run spellintian only if it is the requested task + spellingfiles=$(eval "find ./ -type f -and ! \( \ + $SPELLINGBLACKLIST \ + \) | xargs") + # count the number of spellintian errors + spellingerrors=$(zrun spellintian $spellingfiles 2>&1 | wc -l) + if [[ $spellingerrors -ne 0 ]]; then + # print the output for info + zrun spellintian $spellingfiles + echo "Found $spellingerrors spelling errors via spellintian" + exit 1; + else + echo "Found $spellingerrors spelling errors via spellintian" + fi; +elif [[ $TASK = 'codespell' ]]; then + # run codespell only if it is the requested task + spellingfiles=$(eval "find ./ -type f -and ! \( \ + $SPELLINGBLACKLIST \ + \) | xargs") + # count the number of codespell errors + spellingerrors=$(zrun codespell --check-filenames --quiet 2 --regex "[a-zA-Z0-9][\\-'a-zA-Z0-9]+[a-zA-Z0-9]" $spellingfiles 2>&1 | wc -l) + if [[ $spellingerrors -ne 0 ]]; then + # print the output for info + zrun codespell --check-filenames --quiet 2 --regex "[a-zA-Z0-9][\\-'a-zA-Z0-9]+[a-zA-Z0-9]" $spellingfiles + echo "Found $spellingerrors spelling errors via codespell" + exit 1; + else + echo "Found $spellingerrors spelling errors via codespell" + fi; +else + platformio ci --lib="." --board=$BOARD +fi From 14752b38e5294016540d39e504a4341ded096b6b Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Thu, 28 Jun 2018 01:04:29 +0100 Subject: [PATCH 2/8] Add Travis --- .travis.yml | 92 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 0000000..fd2e43a --- /dev/null +++ b/.travis.yml @@ -0,0 +1,92 @@ +language: python +python: + - "2.7" + +os: linux +dist: trusty +# Short duration job, use the container/without sudo image as it boots faster +sudo: false +# Use the latest Travis images since they are more up to date than the stable release. +group: edge + +before_cache: + - rm -f $HOME/.cache/pip/log/debug.log # erase log + +cache: + directories: + - "~/.platformio" + - $HOME/.cache/pip # pip cache + +env: + global: + # Warnings are errors + - PLATFORMIO_BUILD_FLAGS="-Werror" + +matrix: + fast_finish: true + include: + - env: BOARD=teensylc PLATFORMIO_CI_SRC=examples/UDPReceive + - env: BOARD=teensylc PLATFORMIO_CI_SRC=examples/UDPSendBundle + - env: BOARD=teensylc PLATFORMIO_CI_SRC=examples/UDPSendBundlewithTimeTag + - env: BOARD=teensylc PLATFORMIO_CI_SRC=examples/UDPSendMessage + + - env: BOARD=teensy30 PLATFORMIO_CI_SRC=examples/UDPReceive + - env: BOARD=teensy30 PLATFORMIO_CI_SRC=examples/UDPSendBundle + - env: BOARD=teensy30 PLATFORMIO_CI_SRC=examples/UDPSendBundlewithTimeTag + - env: BOARD=teensy30 PLATFORMIO_CI_SRC=examples/UDPSendMessage + + - env: BOARD=teensy31 PLATFORMIO_CI_SRC=examples/UDPReceive + - env: BOARD=teensy31 PLATFORMIO_CI_SRC=examples/UDPSendBundle + - env: BOARD=teensy31 PLATFORMIO_CI_SRC=examples/UDPSendBundlewithTimeTag + - env: BOARD=teensy31 PLATFORMIO_CI_SRC=examples/UDPSendMessage + + - env: BOARD=teensy35 PLATFORMIO_CI_SRC=examples/UDPReceive + - env: BOARD=teensy35 PLATFORMIO_CI_SRC=examples/UDPSendBundle + - env: BOARD=teensy35 PLATFORMIO_CI_SRC=examples/UDPSendBundlewithTimeTag + - env: BOARD=teensy35 PLATFORMIO_CI_SRC=examples/UDPSendMessage + + - env: BOARD=teensy36 PLATFORMIO_CI_SRC=examples/UDPReceive + - env: BOARD=teensy36 PLATFORMIO_CI_SRC=examples/UDPSendBundle + - env: BOARD=teensy36 PLATFORMIO_CI_SRC=examples/UDPSendBundlewithTimeTag + - env: BOARD=teensy36 PLATFORMIO_CI_SRC=examples/UDPSendMessage + + - os: linux + dist: trusty + # Short duration job, would use the container/without sudo image as it boots faster, but we need a backported lintian, so don't + sudo: required + env: TASK='spellintian' + addons: + apt: + packages: + - moreutils + - os: linux + dist: trusty + # Short duration job, would use the container/without sudo image as it boots faster, but we need a backported lintian, so don't + sudo: required + env: TASK='spellintian-duplicates' + addons: + apt: + packages: + - moreutils + - os: linux + dist: trusty + env: TASK='codespell' + addons: + apt: + packages: + - moreutils + + allow_failures: + - os: linux + dist: trusty + env: TASK='spellintian-duplicates' + +before_install: + - if [ "$TASK" == "spellintian" -o "$TASK" == "spellintian-duplicates" ]; then sudo add-apt-repository ppa:waja/trusty-backports -y; sudo apt-get update -qq; sudo apt-get install lintian -y; fi # Install a late enough lintian + +install: + - if [ -z "$TASK" ]; then pip install --upgrade platformio; fi + - if [ "$TASK" = "codespell" ]; then pip install --upgrade git+https://github.com/codespell-project/codespell.git; fi + +script: + - bash -ex .travis-ci.sh From 835090aaff9dea25996a33e13271778cfa99f85e Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Thu, 28 Jun 2018 01:16:46 +0100 Subject: [PATCH 3/8] Add the badge to the Readme --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index bd035f0..1a38826 100755 --- a/README.md +++ b/README.md @@ -1,3 +1,5 @@ +[![Build Status](https://travis-ci.com/CNMAT/OSC.svg?branch=master)](https://travis-ci.com/CNMAT/OSC) + # OSC for Arduino This is an Arduino and Teensy library implementation of the [OSC](http://opensoundcontrol.org) (Open Sound Control) encoding.It was developed primarily by Yotam Mann and Adrian Freed at CNMAT where OSC was invented. It benefits from contributions from John MacCallum, Matt Wright, Jeff Lubow and Andy Schmeder and many beta testers. @@ -232,4 +234,4 @@ The serial examples use a 9600 baud rate which is reliable on most of the FTDI b We welcome and appreciate your contributions and feedback. # New in this release -ESPxx, M0, PIC32 \ No newline at end of file +ESPxx, M0, PIC32 From c2ca8c455c889f48da4144729f8b85a0c3270c24 Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Tue, 17 Jul 2018 13:49:54 +0100 Subject: [PATCH 4/8] Fix some codespell errors --- .codespellignore | 1 + .travis-ci.sh | 4 ++-- .../Processing/SLIPSerialToUDP/SLIPSerialToUDP.pde | 4 ++-- Applications/Processing/SLIPSerialToUDPp3 | 4 ++-- .../Processing/UDPReceiveBundle/UDPReceiveBundle.pde | 2 +- .../Processing/UDPReceiveMessage/UDPReceiveMessage.pde | 2 +- OSCBundle.cpp | 2 +- OSCMessage.cpp | 8 ++++---- OSCMessage.h | 2 +- examples/OSCEsplora/OSCEsplora.ino | 2 +- .../SerialOscuinoAdaFruitPlayGroundExpresswithBundles.ino | 2 +- .../SerialOscuinoForFubarino/SerialOscuinoForFubarino.ino | 2 +- examples/SerialOscuinoGemmaM0/SerialOscuinoGemmaM0.ino | 2 +- .../SerialOscuinowithBundles/SerialOscuinowithBundles.ino | 2 +- .../SerialOscuinowithMessages.ino | 2 +- examples/UDPOscuino/UDPOscuino.ino | 2 +- examples/UDPReceive/UDPReceive.ino | 2 +- test/OSCMessage_test/OSCMessage_test.ino | 4 ++-- 18 files changed, 25 insertions(+), 24 deletions(-) create mode 100644 .codespellignore diff --git a/.codespellignore b/.codespellignore new file mode 100644 index 0000000..5d1be43 --- /dev/null +++ b/.codespellignore @@ -0,0 +1 @@ + "text" : "Serial Oscuino sends and receives OSC packets over SLIPSerial \nto and from an Arduino or Teensy running the oscuinoSerial Sketch \n\n" diff --git a/.travis-ci.sh b/.travis-ci.sh index c3fc4d3..d7d980f 100644 --- a/.travis-ci.sh +++ b/.travis-ci.sh @@ -70,10 +70,10 @@ elif [[ $TASK = 'codespell' ]]; then $SPELLINGBLACKLIST \ \) | xargs") # count the number of codespell errors - spellingerrors=$(zrun codespell --check-filenames --quiet 2 --regex "[a-zA-Z0-9][\\-'a-zA-Z0-9]+[a-zA-Z0-9]" $spellingfiles 2>&1 | wc -l) + spellingerrors=$(zrun codespell --check-filenames --quiet 2 --regex "[a-zA-Z0-9][\\-'a-zA-Z0-9]+[a-zA-Z0-9]" --exclude-file .codespellignore $spellingfiles 2>&1 | wc -l) if [[ $spellingerrors -ne 0 ]]; then # print the output for info - zrun codespell --check-filenames --quiet 2 --regex "[a-zA-Z0-9][\\-'a-zA-Z0-9]+[a-zA-Z0-9]" $spellingfiles + zrun codespell --check-filenames --quiet 2 --regex "[a-zA-Z0-9][\\-'a-zA-Z0-9]+[a-zA-Z0-9]" --exclude-file .codespellignore $spellingfiles echo "Found $spellingerrors spelling errors via codespell" exit 1; else diff --git a/Applications/Processing/SLIPSerialToUDP/SLIPSerialToUDP.pde b/Applications/Processing/SLIPSerialToUDP/SLIPSerialToUDP.pde index 97f8215..1d5046b 100644 --- a/Applications/Processing/SLIPSerialToUDP/SLIPSerialToUDP.pde +++ b/Applications/Processing/SLIPSerialToUDP/SLIPSerialToUDP.pde @@ -192,7 +192,7 @@ public void STOP() { SERIAL ************************************************************************************/ -//the Serial communcation to the Arduino +//the Serial communication to the Arduino Serial serial; String[] serialRateStrings = { @@ -314,7 +314,7 @@ void UDPSendBuffer(byte[] data) { udp.send( data, ipAddress, outPort ); } -//called when UDP recieves some data +//called when UDP receives some data void receive( byte[] data) { drawIncomingUDP(); //send it over to serial diff --git a/Applications/Processing/SLIPSerialToUDPp3 b/Applications/Processing/SLIPSerialToUDPp3 index 3a57045..e5c3ad6 100644 --- a/Applications/Processing/SLIPSerialToUDPp3 +++ b/Applications/Processing/SLIPSerialToUDPp3 @@ -192,7 +192,7 @@ public void STOP() { SERIAL ************************************************************************************/ -//the Serial communcation to the Arduino +//the Serial communication to the Arduino Serial serial; String[] serialRateStrings = { //less baudrates, only hi speeds @@ -315,7 +315,7 @@ void UDPSendBuffer(byte[] data) { udp.send( data, ipAddress, outPort ); } -//called when UDP recieves some data +//called when UDP receives some data void receive( byte[] data) { drawIncomingUDP(); //send it over to serial diff --git a/Applications/Processing/UDPReceiveBundle/UDPReceiveBundle.pde b/Applications/Processing/UDPReceiveBundle/UDPReceiveBundle.pde index 77590b6..466ddbf 100644 --- a/Applications/Processing/UDPReceiveBundle/UDPReceiveBundle.pde +++ b/Applications/Processing/UDPReceiveBundle/UDPReceiveBundle.pde @@ -4,7 +4,7 @@ Receives and visualizes OSCBundles sent over UDP Use with /examples/UDPSendBundle or with /examples/SerialSendBundle in conjunction -with /Applicaitons/Processing/SLIPSerialToUDP +with /Applications/Processing/SLIPSerialToUDP */ import oscP5.*; diff --git a/Applications/Processing/UDPReceiveMessage/UDPReceiveMessage.pde b/Applications/Processing/UDPReceiveMessage/UDPReceiveMessage.pde index 75c3dd1..9856bcd 100644 --- a/Applications/Processing/UDPReceiveMessage/UDPReceiveMessage.pde +++ b/Applications/Processing/UDPReceiveMessage/UDPReceiveMessage.pde @@ -4,7 +4,7 @@ Receives and visualizes OSCBundles sent over UDP Use with /examples/UDPSendMessage or with /examples/SerialSendMessage in conjunction -with /Applicaitons/Processing/SLIPSerialToUDP +with /Applications/Processing/SLIPSerialToUDP */ import oscP5.*; diff --git a/OSCBundle.cpp b/OSCBundle.cpp index 1fb1416..3957c11 100644 --- a/OSCBundle.cpp +++ b/OSCBundle.cpp @@ -218,7 +218,7 @@ OSCBundle& OSCBundle::send(Print &p){ //turn the message size into a pointer uint32_t s32 = BigEndian((uint32_t) msgSize); uint8_t * sptr = (uint8_t *) &s32; - //write the messsage size + //write the message size p.write(sptr, 4); msg->send(p); } diff --git a/OSCMessage.cpp b/OSCMessage.cpp index 96d10de..7ec23b7 100755 --- a/OSCMessage.cpp +++ b/OSCMessage.cpp @@ -83,7 +83,7 @@ OSCMessage::~OSCMessage(){ OSCMessage& OSCMessage::empty(){ error = OSC_OK; - //free each of hte data in the array + //free each of the data in the array for (int i = 0; i < dataCount; i++){ OSCData * datum = getOSCData(i); //explicitly destruct the data @@ -449,7 +449,7 @@ int OSCMessage::bytes(){ //padding amount int addrPad = padSize(addrLen); messageSize += addrPad; - //add the comma seperator + //add the comma separator messageSize += 1; //add the types messageSize += dataCount; @@ -506,7 +506,7 @@ OSCMessage& OSCMessage::send(Print &p){ while(addrPad--){ p.write(nullChar); } - //add the comma seperator + //add the comma separator p.write((uint8_t) ','); //add the types #ifdef PAULSSUGGESTION @@ -589,7 +589,7 @@ OSCMessage& OSCMessage::fill(uint8_t * incomingBytes, int length){ void OSCMessage::decodeAddress(){ setAddress((char *) incomingBuffer); - //change the error from invalide message + //change the error from invalid message error = OSC_OK; clearIncomingBuffer(); } diff --git a/OSCMessage.h b/OSCMessage.h index 2205eed..24f7c6d 100755 --- a/OSCMessage.h +++ b/OSCMessage.h @@ -111,7 +111,7 @@ class OSCMessage //new constructor needs an address OSCMessage (const char * _address); //no address - //placeholder since it's invalide OSC + //placeholder since it's invalid OSC OSCMessage(); //can optionally accept all of the data after the address diff --git a/examples/OSCEsplora/OSCEsplora.ino b/examples/OSCEsplora/OSCEsplora.ino index 14fc82d..be6270d 100644 --- a/examples/OSCEsplora/OSCEsplora.ino +++ b/examples/OSCEsplora/OSCEsplora.ino @@ -198,7 +198,7 @@ void loop(){ // The COOKED OSC address space and parameter mappings // encode data for ease of use and legibility at the host. Unit intervals replace integers - // The names are chosen to clarify usage rather than adherance to the silkscreen + // The names are chosen to clarify usage rather than adherence to the silkscreen // also values are acquired as close together as reasonably possible to increase // their usability in sensor fusion contexts, i.e. in this case with the accelerometer diff --git a/examples/SerialOscuinoAdaFruitPlayGroundExpresswithBundles/SerialOscuinoAdaFruitPlayGroundExpresswithBundles.ino b/examples/SerialOscuinoAdaFruitPlayGroundExpresswithBundles/SerialOscuinoAdaFruitPlayGroundExpresswithBundles.ino index 9629fad..bfd81fc 100644 --- a/examples/SerialOscuinoAdaFruitPlayGroundExpresswithBundles/SerialOscuinoAdaFruitPlayGroundExpresswithBundles.ino +++ b/examples/SerialOscuinoAdaFruitPlayGroundExpresswithBundles/SerialOscuinoAdaFruitPlayGroundExpresswithBundles.ino @@ -162,7 +162,7 @@ void routeAnalog(OSCMessage &msg, int addrOffset ){ * format: * /tone/pin * - * (digital value) (float value) = freqency in Hz + * (digital value) (float value) = frequency in Hz * (no value) disable tone * **/ diff --git a/examples/SerialOscuinoForFubarino/SerialOscuinoForFubarino.ino b/examples/SerialOscuinoForFubarino/SerialOscuinoForFubarino.ino index 022a712..87d03cd 100644 --- a/examples/SerialOscuinoForFubarino/SerialOscuinoForFubarino.ino +++ b/examples/SerialOscuinoForFubarino/SerialOscuinoForFubarino.ino @@ -174,7 +174,7 @@ void routeAnalog(OSCMessage &msg, int addrOffset ){ * format: * /tone/pin * - * (digital value) (float value) = freqency in Hz + * (digital value) (float value) = frequency in Hz * (no value) disable tone * **/ diff --git a/examples/SerialOscuinoGemmaM0/SerialOscuinoGemmaM0.ino b/examples/SerialOscuinoGemmaM0/SerialOscuinoGemmaM0.ino index b066012..ba729b4 100644 --- a/examples/SerialOscuinoGemmaM0/SerialOscuinoGemmaM0.ino +++ b/examples/SerialOscuinoGemmaM0/SerialOscuinoGemmaM0.ino @@ -168,7 +168,7 @@ void routeAnalog(OSCMessage &msg, int addrOffset ){ * format: * /tone/pin * - * (digital value) (float value) = freqency in Hz + * (digital value) (float value) = frequency in Hz * (no value) disable tone * **/ diff --git a/examples/SerialOscuinowithBundles/SerialOscuinowithBundles.ino b/examples/SerialOscuinowithBundles/SerialOscuinowithBundles.ino index 8c1142e..d8fef62 100644 --- a/examples/SerialOscuinowithBundles/SerialOscuinowithBundles.ino +++ b/examples/SerialOscuinowithBundles/SerialOscuinowithBundles.ino @@ -162,7 +162,7 @@ void routeAnalog(OSCMessage &msg, int addrOffset ){ * format: * /tone/pin * - * (digital value) (float value) = freqency in Hz + * (digital value) (float value) = frequency in Hz * (no value) disable tone * **/ diff --git a/examples/SerialOscuinowithMessages/SerialOscuinowithMessages.ino b/examples/SerialOscuinowithMessages/SerialOscuinowithMessages.ino index 407de26..6901063 100644 --- a/examples/SerialOscuinowithMessages/SerialOscuinowithMessages.ino +++ b/examples/SerialOscuinowithMessages/SerialOscuinowithMessages.ino @@ -169,7 +169,7 @@ void routeAnalog(OSCMessage &msg, int addrOffset ){ * format: * /tone/pin * - * (digital value) (float value) = freqency in Hz + * (digital value) (float value) = frequency in Hz * (no value) disable tone * **/ diff --git a/examples/UDPOscuino/UDPOscuino.ino b/examples/UDPOscuino/UDPOscuino.ino index fe50799..9fdafea 100644 --- a/examples/UDPOscuino/UDPOscuino.ino +++ b/examples/UDPOscuino/UDPOscuino.ino @@ -199,7 +199,7 @@ void routeAnalog(OSCMessage &msg, int addrOffset ){ * format: * /tone/pin * - * (digital value) (float value) = freqency in Hz + * (digital value) (float value) = frequency in Hz * (no value) disable tone * **/ diff --git a/examples/UDPReceive/UDPReceive.ino b/examples/UDPReceive/UDPReceive.ino index 5bfdd69..060db8b 100644 --- a/examples/UDPReceive/UDPReceive.ino +++ b/examples/UDPReceive/UDPReceive.ino @@ -50,7 +50,7 @@ char * numToOSCAddress( int pin){ * format: * /tone/pin * - * (digital value) (float value) = freqency in Hz + * (digital value) (float value) = frequency in Hz * (no value) disable tone * **/ diff --git a/test/OSCMessage_test/OSCMessage_test.ino b/test/OSCMessage_test/OSCMessage_test.ino index 3684da1..3f5707a 100644 --- a/test/OSCMessage_test/OSCMessage_test.ino +++ b/test/OSCMessage_test/OSCMessage_test.ino @@ -4,14 +4,14 @@ #define HAS_DOUBLE sizeof(double) == 8 -test(message_addres){ +test(message_address){ OSCMessage msg("/hihi"); char addr[6]; msg.getAddress(addr); assertEqual(strcmp(addr, "/hihi"), 0); } -test(message_addres_offset){ +test(message_address_offset){ OSCMessage msg("/foo/bar"); char addr[5]; msg.getAddress(addr, 4); From edd6bf1b2c924637bba69ffc401e45761d604818 Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Tue, 17 Jul 2018 13:52:34 +0100 Subject: [PATCH 5/8] Ignore inevitable spelling errors in the .codespellignore file --- .travis-ci.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis-ci.sh b/.travis-ci.sh index d7d980f..80cb733 100644 --- a/.travis-ci.sh +++ b/.travis-ci.sh @@ -8,6 +8,7 @@ set -e CPP_LINT_URL="https://raw.githubusercontent.com/google/styleguide/gh-pages/cpplint/cpplint.py"; SPELLINGBLACKLIST=$(cat <<-BLACKLIST + -wholename "./.codespellignore" -or \ -wholename "./.git/*" BLACKLIST ) From d28dee44388ee5432c6330ea8dc128dc3e5e593d Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Tue, 17 Jul 2018 14:06:58 +0100 Subject: [PATCH 6/8] Don't complain about deprecated declarations, as some exist in the core libs --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index fd2e43a..dbd1e49 100644 --- a/.travis.yml +++ b/.travis.yml @@ -20,7 +20,7 @@ cache: env: global: # Warnings are errors - - PLATFORMIO_BUILD_FLAGS="-Werror" + - PLATFORMIO_BUILD_FLAGS="-Werror -Wno-error=deprecated-declarations" matrix: fast_finish: true From 3067f7d8740953db6ac6f66b89aeaa7b4836a3e9 Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Tue, 25 Sep 2018 12:05:34 +0100 Subject: [PATCH 7/8] More SPaG --- SLIPEncodedUSBSerial.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SLIPEncodedUSBSerial.cpp b/SLIPEncodedUSBSerial.cpp index 2318809..2e17080 100644 --- a/SLIPEncodedUSBSerial.cpp +++ b/SLIPEncodedUSBSerial.cpp @@ -4,7 +4,7 @@ /* CONSTRUCTOR */ -//instantiate with the tranmission layer +//instantiate with the transmission layer #if (defined(CORE_TEENSY) && defined(USB_SERIAL)) || (!defined(CORE_TEENSY) && defined(__AVR_ATmega32U4__)) || defined(__SAM3X8E__) || (defined(_USB) && defined(_USE_USB_FOR_SERIAL_)) || defined(BOARD_maple_mini) || defined(_SAMD21_) || defined(__ARM__) || (defined(__PIC32MX__) || defined(__PIC32MZ__)) From 95654cec14e337150882245d9b5235ee1fba4f96 Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Tue, 25 Sep 2018 12:05:58 +0100 Subject: [PATCH 8/8] Fix another typo --- SLIPEncodedSerial.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SLIPEncodedSerial.cpp b/SLIPEncodedSerial.cpp index 2f689ce..f6a43c6 100644 --- a/SLIPEncodedSerial.cpp +++ b/SLIPEncodedSerial.cpp @@ -3,7 +3,7 @@ /* CONSTRUCTOR */ -//instantiate with the tranmission layer +//instantiate with the transmission layer //use HardwareSerial SLIPEncodedSerial::SLIPEncodedSerial(HardwareSerial &s){ serial = &s;