I dont understand how the ComplexGooglePlaceAutocompleteType works

[beejaz]

Hi,

Could you help me with the ComplexType-object, I cant get it to work. I must be doing something totally wrong.

In my OrderController, ive added:
use Cethyworks\GooglePlaceAutocompleteBundle\Form\ComplexGooglePlaceAutocompleteType;
->add('maps', ComplexGooglePlaceAutocompleteType::class, ["mapped" => false]);

I get match with Autocomplete function from Google and I press Send, but the form only sends this to the controller:
array(11) { ["maps"]=> array(3) { ["name"]=> string(0) "" ["address_components"]=> string(205) "[{"long_name":null,"types":["street_number"]},{"long_name":null,"types":["route"]},{"long_name":null,"types":["locality"]},{"long_name":null,"types":["postal_code"]},{"long_name":null,"types":["country"]}]" ["autocomplete"]=> string(31) "Examplestreet 100, Stockholm, Sverige" } ["_token"]=> string(43) "r-LNm0oijTqOqh2j6VDCZJ5fQ57GGmteEtuJaN3HDF4" }

My entity for Order has:
/**
* @var Place
*
* @Orm\Embedded(class="Cethyworks\GooglePlaceAutocompleteBundle\Model\Place")
*
*/
private $locationAddress;

And the error i get is:
SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'location_address_name' cannot be null

Can you point me in the correct direction? :)

[Cethy]

Hi beejaz,
The Place entity needs its prop name to not be empty. You can check the doctrine mapping here :
https://github.com/Cethy/GooglePlaceAutocompleteBundle/blob/master/src/Resources/config/doctrine-mapping/Place.orm.yml
That said, this is curious : the DataTransformer should populate the prop name with the content of the field autocomplete.
Could you check if the dataTransformer is called (https://github.com/Cethy/GooglePlaceAutocompleteBundle/blob/master/src/Form/DataTransformer/ComplexGooglePlaceAutocompleteDataTransformer.php#L53) in your case ?

[beejaz]

Hi Cethy, thansk for your reply.

If I dump the $request->request->get('order')['maps']) now in the controller handling the request/formsubmit i get the array like this:

array(3) { ["name"]=> string(12) "Streetname 32" ["address_components"]=> string(599) "[{"long_name":"32","short_name":"32","types":["street_number"]},{"long_name":"Streetname","short_name":"Streetname","types":["route"]},{"long_name":"XXX","short_name":"XXX","types":["sublocality_level_1","sublocality","political"]},{"long_name":"XXX","short_name":"XXX","types":["postal_town"]},{"long_name":"Stockholms län","short_name":"Stockholms län","types":["administrative_area_level_1","political"]},{"long_name":"Sverige","short_name":"SE","types":["country","political"]},{"long_name":"XXX XX","short_name":"XXX XX","types":["postal_code"]}]" ["autocomplete"]=> string(31) "Streetname 32, XXX, Sverige" }

But Im missing something because it doenst get transformed to a Place object. Do I need to create the place object from the form request in the controller or how should i transform the array/string to object?

[Cethy]

$request contains the raw data, this works as expected.
If you want to check the Place object, you need to dump $form->getData() after processing :

    $form->handleRequest($request);
    if ($form->isSubmitted() && $form->isValid()) {
        // $form->getData() holds the submitted values
        $here = $form->getData();
        // ...

If you don't have the transformed data here, you might have a configuration problem ; Which version of symfony do you use ? Could you paste your complete Controller::action (how do you create the form in the first place) ?

[beejaz]

Hi Cethy, I managed to get it to work now sort of. I believed I missed some code and got lost. I got it working by adding, to the entity:

    public function __construct()
{
	$this->locationAddress = new Place("");
}

public function getLocationAddress(): Place
{
    return $this->locationAddress;
}

public function setLocationAddress(Place $locationAddress): self
{
    $this->locationAddress = $locationAddress;

    return $this;
}

If i remove the construct or remove "" it will complain about not a Place-object or null value.

But now it persist entity correctly. Only problem now is with this code:
->add('locationAddress', ComplexGooglePlaceAutocompleteType::class, ['help' => 'Its important to include correct address.',]);

I get double labels, one for locationAddress and one that gets autoadded for Autocomplete:

[beejaz]

Also, when I press ENTER-button after using arrows to select a address, i get this error 500:

Expected argument of type "Cethyworks\GooglePlaceAutocompleteBundle\Model\Place", "NULL" given at property path "locationAddress".

Do you have any idea of what im missing here also? If i chose the same option with mouse instead, everything works. Its just when i scroll with arrows and press enter on googles suggestion

[Cethy]

@beejaz you should not have to initialize the Place object. the transformer called by the form should do it for you.

For the nested form, something like {{ form_row(form.locationAddress.autocomplete) }} might do the trick.

And for the last problem, I noticed it and sadly could not find a solution. You can find how the js works here.
The place_changed event seems to not fire when navigating the form with the keyboard, therefore
it never get the google place data.

[beejaz]

Thanks for info Cethy. Really appreciated. I will try to use it without construct later today but I think it doesn't work for me then.

I also noticed locality didn't work in Sweden, it was always null. I added postalTown and got it to work, I don't know if its a Google maps change recently?

I also noticed there is deprecation messages on symfony 4.3, may I ask if you will take a look on them? I mean, are you actively maintaining new versions or should I try to sort them by myself? Thanks

[Cethy]

By default, I switched to building API-only w/ symfony (no Form, no Twig), but I'm supposed to use this bundle on a new sf4 project in the near future, I will fix what I can at this moment.
But I welcome PRs if you want to make it better. ;)

I couldn't find postalTown (or postal_town) anywhere in the API doc and the google results are not many. Is it a special case for your country ?

[beejaz]

Nice, I will try to see if I make some PR with the fixes before you do =)

When Im searching for addresses in my country I get this, we use postal town here, I dont know if its just our country. I think I read something a year or so ago that google added it.

"types" : [ "postal_town" ]

{
  "html_attributions": [
    
  ],
  "result": {
    "address_components": [
      {
        "long_name": "100",
        "short_name": "100",
        "types": [
          "street_number"
        ]
      },
      {
        "long_name": "Drottninggatan",
        "short_name": "Drottninggatan",
        "types": [
          "route"
        ]
      },
      {
        "long_name": "Norrmalm",
        "short_name": "Norrmalm",
        "types": [
          "sublocality_level_1",
          "sublocality",
          "political"
        ]
      },
      {
        "long_name": "Stockholm",
        "short_name": "Stockholm",
        "types": [
          "postal_town"
        ]
      },
      {
        "long_name": "Stockholms l\u00e4n",
        "short_name": "Stockholms l\u00e4n",
        "types": [
          "administrative_area_level_1",
          "political"
        ]
      },
      {
        "long_name": "Sverige",
        "short_name": "SE",
        "types": [
          "country",
          "political"
        ]
      },
      {
        "long_name": "111 60",
        "short_name": "111 60",
        "types": [
          "postal_code"
        ]
      }
    ],
    "adr_address": "<span class=\"street-address\">Drottninggatan 100<\/span>, <span class=\"postal-code\">111 60<\/span> <span class=\"locality\">Stockholm<\/span>, <span class=\"country-name\">Sverige<\/span>",
    "formatted_address": "Drottninggatan 100, 111 60 Stockholm, Sverige",
    "geometry": {
      "location": {
        "lat": 59.3380546,
        "lng": 18.0573795
      },
      "viewport": {
        "northeast": {
          "lat": 59.339325630291,
          "lng": 18.058681380291
        },
        "southwest": {
          "lat": 59.336627669708,
          "lng": 18.055983419709
        }
      }
    },
    "icon": "https:\/\/maps.gstatic.com\/mapfiles\/place_api\/icons\/geocode-71.png",
    "id": "d374ca24f71252928ab66ac0cd2d96ef497a6a11",
    "name": "Drottninggatan 100",
    "place_id": "ChIJB0__aWadX0YRXm3WGVn3s4s",
    "plus_code": {
      "compound_code": "83Q4+6X Stockholm, Sverige",
      "global_code": "9FFW83Q4+6X"
    },
    "reference": "ChIJB0__aWadX0YRXm3WGVn3s4s",
    "scope": "GOOGLE",
    "types": [
      "street_address"
    ],
    "url": "https:\/\/maps.google.com\/?q=Drottninggatan+100,+111+60+Stockholm,+Sverige&ftid=0x465f9d6669ff4f07:0x8bb3f75919d66d5e",
    "utc_offset": 120,
    "vicinity": "Norrmalm"
  },
  "status": "OK"
}

[Cethy]

It will not be easy, with the bundle in this state, to address this final problem.
Everything is too tightly coupled.

What I would do is copy ComplexGooglePlaceAutocompleteType and replace ComplexGooglePlaceAutocompleteDataTransformer by my own, which would use the postal_town.

What would make sense is refactor ComplexGooglePlaceAutocompleteType to accept the transformer as a service and configure its "overiddability". If you're up for it.