errors changed to new error Classes

Author: Chmod351

README.md

@@ -9,9 +9,11 @@
 This project is a web application developed using Node.js v16.20.1. It follows the Model-View-Controller (MVC) architectural pattern, providing a structured and modular approach to building web applications.
 
 # THIS DOCUMENTATION IS NOT FINISHED AT THE MOMENT
+
 ## Development Environment Setup
 
 To set up the development environment for this project, follow these steps:
+
 - [Docker File](https://hub.docker.com/repository/docker/clamshell6412/ecomerce_res_api/general) (production only)
 - Install Node.js v16.20.1 (or a compatible version) on your system.
 - Clone the project repository from [repository URL].
@@ -42,12 +44,12 @@ STRIPE_TOKEN=sk_text_z&&2DbCJa9d3gZkxFwJdE$&hHbRe47KHxAF%&N#qRVx*zVFG$W
 
 ### User
 
-| User Actions    | Routes                    | Required                  | Http Verb |
-| --------------- | ------------------------- | ------------------------- | --------- |
-| Sign In         | `/api/users/signIn`       | email, username, password | Post      |
-| Sign Up         | `/api/users/signUp`       | email, password           | Post      |
-| User Stats      | `/api/users/stats`        | must by Admin             | Get       |
-| Find user by Id | `/api/users/find/:userId` | userId                    | Get       |
+| User Actions    | Routes                    | Required                   | Http Verb |
+| --------------- | ------------------------- | -------------------------- | --------- |
+| Sign In         | `/api/users/signIn`       | email , password           | Post      |
+| Sign Up         | `/api/users/signUp`       | email, password , password | Post      |
+| User Stats      | `/api/users/stats`        | must by Admin              | Get       |
+| Find user by Id | `/api/users/find/:userId` | userId                     | Get       |
 
 [Postman Documentation]()
 

index.js

@@ -7,7 +7,7 @@ import cart from './server/Routes/shoppingCartRoutes.js';
 import product from './server/Routes/productRoutes.js';
 import purchase from './server/Routes/purchasesRoutes.js';
 import comment from './server/Routes/commentsRoutes.js';
-import errorHandler from './server/helpers/errorHandler.js';
+import { errorHandler } from './server/helpers/errorHandler.js';
 
 //config
 

package-lock.json

@@ -1,5 +1,6 @@
 import Product from '../Models/productModel.js';
 import mongoose from 'mongoose';
+import { NotFoundError } from '../helpers/errorHandler.js';
 
 const productService = {
   getProduct,
@@ -25,7 +26,7 @@ async function getProductById(productId) {
     const product = await Product.findById(productId);
     return product;
   } else {
-    throw new Error('not found');
+    throw new NotFoundError('Product Not found');
   }
 }
 

server/View/productView.js

@@ -2,6 +2,11 @@ import Encrypt from '../helpers/bcrypt.js';
 import User from '../Models/userModel.js';
 import { JWT_TOKEN } from '../../index.js';
 import Token from '../helpers/token.js';
+import {
+  BadRequestError,
+  NotFoundError,
+  UnauthorizedError,
+} from '../helpers/errorHandler.js';
 
 //config
 const userService = {
@@ -35,7 +40,7 @@ async function signIn(user) {
       existingUser.password,
     );
     if (!isPasswordMatch) {
-      throw new Error('wrong credentials');
+      throw new UnauthorizedError('wrong credentials');
     } else {
       const userId = existingUser._id.toString();
       const token = await jwt.generateToken(userId, JWT_TOKEN, {
@@ -46,6 +51,14 @@ async function signIn(user) {
   }
 }
 
+async function checkLength(item, num) {
+  if (item.lenght >= num) {
+    return true;
+  } else {
+    throw new BadRequestError(`the minimum allowed is ${num}`);
+  }
+}
+
 async function signUp(user) {
   const allowedFields = ['email', 'password', 'username'];
 
@@ -57,13 +70,14 @@ async function signUp(user) {
     }, {});
 
   const registeredUser = await findByEmail(filteredUser.email);
-  if (!registeredUser) {
+  const validatePass = await checkLength(filteredUser.password, 8);
+  if (!registeredUser && validatePass) {
     const encryptPassword = await encrypt.hashPassword(filteredUser.password);
     const createUser = new User({ ...filteredUser, password: encryptPassword });
     const newUser = await createUser.save();
     return newUser;
   } else {
-    throw new Error('bad request');
+    throw new BadRequestError('email already in use');
   }
 }
 
@@ -72,7 +86,7 @@ async function getUser(userId) {
   if (user) {
     return user;
   } else {
-    throw new Error('not found');
+    throw new NotFoundError('User Not found');
   }
 }
 

server/View/usersViews.js

@@ -1,11 +1,12 @@
 import User from '../Models/userModel.js';
+import { UnauthorizedError } from './errorHandler.js';
 
 async function adminCheck(req, res, next) {
   const user = await User.findById(req.user.id);
   if (user.isAdmin) {
     next();
   } else {
-    next(new Error('unauthorized'));
+    next(new UnauthorizedError('You are Unauthorized'));
   }
 }
 

server/helpers/adminCheck.js

@@ -1,16 +1,45 @@
+class NotFoundError extends Error {
+  constructor(message) {
+    super(message);
+    this.name = 'NotFoundError';
+    this.statusCode = 404;
+  }
+}
+
+class AuthenticationError extends Error {
+  constructor(message) {
+    super(message);
+    this.name = 'AuthenticationError';
+    this.statusCode = 401;
+  }
+}
+
+class UnauthorizedError extends Error {
+  constructor(message) {
+    super(message);
+    this.name = 'UnauthorizedError';
+    this.statusCode = 403;
+  }
+}
+class BadRequestError extends Error {
+  constructor(message) {
+    super(message);
+    this.name = 'BadRequestError';
+    this.statusCode = 400;
+  }
+}
+
 function errorHandler(error, req, res, next) {
-  if (error.message === 'bad request') {
-    res.status(400).json({ error: 'Bad Request' });
-  } else if (error.message === 'wrong credentials') {
-    res.status(401).json({ error: 'Wrong Credentials' });
-  } else if (error.message === 'unauthorized') {
-    res.status(403).json({ error: 'Unauthorized' });
-  } else if (error.message === 'not found') {
-    res.status(404).json({ error: 'Not Found' });
-  } else if (error.message === 'stripe went wrong') {
-    res.status(500).json({ error: 'Payment went wrong' });
+  if (error.statusCode) {
+    res.status(error.statusCode).json({ error: error.message });
   } else {
-    next(error);
+    res.status(500).json({ error: error.message });
   }
 }
-export default errorHandler;
+export {
+  errorHandler,
+  UnauthorizedError,
+  BadRequestError,
+  AuthenticationError,
+  NotFoundError,
+};