From b9d8e5a54072223e8577740e994590ae6764774a Mon Sep 17 00:00:00 2001 From: Tarek Alqaddy Date: Mon, 5 May 2025 23:58:34 +0300 Subject: [PATCH 1/3] Add optional price attribute to ItemTracked type --- src/types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/types/index.d.ts b/src/types/index.d.ts index ab71e41c..2a22e74a 100644 --- a/src/types/index.d.ts +++ b/src/types/index.d.ts @@ -338,9 +338,9 @@ export interface ItemTracked { itemName?: string; itemId?: string; variationId?: string; + price?: number; } export interface ItemTrackedPurchased extends ItemTracked { - price: number, count: number } From 162877eed9fad0cf1886f0f1770ae0ef780fa433 Mon Sep 17 00:00:00 2001 From: Tarek Alqaddy Date: Tue, 6 May 2025 00:24:16 +0300 Subject: [PATCH 2/3] Specify cspell version to be v8.19.4 in spell-check github action --- .github/workflows/spell-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/spell-check.yml b/.github/workflows/spell-check.yml index 62b0dd35..2cccb878 100644 --- a/.github/workflows/spell-check.yml +++ b/.github/workflows/spell-check.yml @@ -27,4 +27,4 @@ jobs: node-version: ${{ matrix.node }} - name: Spell check - run: npx cspell "**/*.js" + run: npx cspell@v8.19.4 "**/*.js" From 4ebce8579c4617509b9044cdb3858b4ed747830c Mon Sep 17 00:00:00 2001 From: Tarek Alqaddy Date: Tue, 6 May 2025 02:53:59 +0300 Subject: [PATCH 3/3] Update the error message to match the api response --- spec/src/modules/tracker.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/src/modules/tracker.js b/spec/src/modules/tracker.js index 314c2fda..7519645c 100644 --- a/spec/src/modules/tracker.js +++ b/spec/src/modules/tracker.js @@ -4540,7 +4540,7 @@ describe('ConstructorIO - Tracker', () => { // Response expect(responseParams).to.have.property('method').to.equal('POST'); - expect(responseParams).to.have.property('message').to.equal('conversion type must be one of add_to_wishlist, add_to_cart, like, message, make_offer, read. If you wish to use custom types, please set is_custom_type to true and specify a display_name.'); + expect(responseParams).to.have.property('message').to.equal('Invalid parameters'); done(); });