From e17c8f6a436a4734015b47af9a100b6855a3089d Mon Sep 17 00:00:00 2001 From: BooLTonian <80687318+BooLTonian@users.noreply.github.com> Date: Fri, 29 Oct 2021 04:05:55 -0400 Subject: [PATCH] Correct chord forming Your major system was creating augmented chords, and your minor system was creating major chords. As such, I corrected the step count. This should also be paired with a fork I'm putting on Instruments/listeners/InventoryClick.java which will make it so the bool minor actually activates the minor functionality instead of the major functionality. --- src/net/cupofcode/instruments/Utils.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/net/cupofcode/instruments/Utils.java b/src/net/cupofcode/instruments/Utils.java index a676a78..75a80fb 100644 --- a/src/net/cupofcode/instruments/Utils.java +++ b/src/net/cupofcode/instruments/Utils.java @@ -54,13 +54,13 @@ public static String[] getMajorTriad(String note) { int position = getIndexOfNote(note); return new String[] { notes[position], notes[(position + 4) % notes.length], - notes[(position + 8) % notes.length] }; + notes[(position + 7) % notes.length] }; } public static String[] getMinorTriad(String note) { int position = getIndexOfNote(note); - return new String[] { notes[position], notes[(position + 4) % notes.length], + return new String[] { notes[position], notes[(position + 3) % notes.length], notes[(position + 7) % notes.length] }; }