Small rule issue

[kakariki1]

Hello CurlyMoo,

while playing around in Heishamon I found another small issue.
The following rule does not work -> ERROR: Unexpected token

on SetTargetTemperature($Temp) then
  print($Temp)
end

on System#Boot then
  #Setpoint = 33;
  #MainOutletTemp = 25;
  SetTargetTemperature(max(#MainOutletTemp, #Setpoint - 3));
end

After removing the "- 3" it works ...

I also found a small typo here

rules/src/rules/rules.cpp

Line 551 in dee7499

assert(a/sizeof(struct vm_vchat_t *)/2 <= 127);

vm_vchat_t should be vm_vchar_t

Best regards,
lakeroe

[CurlyMoo]

Didn't it give you a line number after the Unexpected token error?

[CurlyMoo]

This unittest works fine btw:

on foo($a) then print($a); end on bar then $a = 1; $b = 2; foo(max($a, $b - 3)); end

Are you using the latest code from this repo?

[kakariki1]

I'm using the latest code from this repo and the line number after the error is 3827.
In the meantime I also found a mistake: Note the missing semicolon after the print statement - Sorry !

BUT, after playing around a bit more I found this not working rule

on foo($a) then
  print($a);
end

on System#Boot then
  $a = 1;
  $b = 2;
  foo(max(ceil($a + 2), $b - 3));
end

ERROR: Unexpected token (3557)

[CurlyMoo]

I indeed narrowed it down to:

if 1 == 1 then $a = max(ceil(3), 3 * 4); end

[kakariki1]

Okay, good news.
But do you also have a solution ?