avoid double array indexing by using ref var

SergeiPavlov · SergeiPavlov · commit 195d9f953d93 · 2022-03-15T20:05:51.000-07:00
diff --git a/Orm/Xtensive.Orm/Tuples/Packed/PackedFieldAccessor.cs b/Orm/Xtensive.Orm/Tuples/Packed/PackedFieldAccessor.cs
@@ -249,10 +249,10 @@ private void Store(PackedTuple tuple, ref PackedFieldDescriptor d, T value)
       }
 
       var encoded = Encode(value);
-      var block = tuple.Values[valueIndex];
+      ref var block = ref tuple.Values[valueIndex];
       var valueBitOffset = d.ValueBitOffset;
       var mask = ValueBitMask << valueBitOffset;
-      tuple.Values[valueIndex] = (block & ~mask) | ((encoded << valueBitOffset) & mask);
+      block = (block & ~mask) | ((encoded << valueBitOffset) & mask);
     }
 
     private T Load(PackedTuple tuple, ref PackedFieldDescriptor d)

Original file line number	Diff line number	Diff line change
`@@ -249,10 +249,10 @@ private void Store(PackedTuple tuple, ref PackedFieldDescriptor d, T value)`
`249`	`249`	`}`
`250`	`250`
`251`	`251`	`var encoded = Encode(value);`
`252`		`- var block = tuple.Values[valueIndex];`
	`252`	`+ ref var block = ref tuple.Values[valueIndex];`
`253`	`253`	`var valueBitOffset = d.ValueBitOffset;`
`254`	`254`	`var mask = ValueBitMask << valueBitOffset;`
`255`		`- tuple.Values[valueIndex] = (block & ~mask) \| ((encoded << valueBitOffset) & mask);`
	`255`	`+ block = (block & ~mask) \| ((encoded << valueBitOffset) & mask);`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`private T Load(PackedTuple tuple, ref PackedFieldDescriptor d)`