Merge pull request #221 from DataObjects-NET/7.0-datetime-ticks-problem

Fixes TimeSpan.Ticks extraction problem

Author: alex-kulakov

ChangeLog/7.0.3_dev.txt

@@ -0,0 +1 @@
+[sqlserver] Fixed TimeSpan.Ticks extraction problem

Orm/Xtensive.Orm.SqlServer/Sql.Drivers.SqlServer/v13/Compiler.cs

@@ -36,7 +36,7 @@ public override void Visit(SqlFunctionCall node)
             // we have to use time consuming algorithm here because
             // DATEDIFF_BIG can throw arithmetic overflow on nanoseconds
             // so we should handle it by this big formula
-            Visit(CastToLong(DateTimeSubtractDateTimeExpensive(binary.Right, binary.Left)));
+            Visit(CastToLong(DateTimeSubtractDateTimeExpensive(binary.Left, binary.Right)));
           }
           else {
             base.Visit(node);

Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/DateTime/PartsExtractionTest.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2016-2021 Xtensive LLC.
+// Copyright (C) 2016-2022 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Alex Groznov
@@ -188,5 +188,14 @@ public void ExtractDayOfWeekTest()
         RunWrongTest<SingleDateTimeEntity>(c => c.NullableDateTime.Value.DayOfWeek == WrongDateTime.DayOfWeek);
       });
     }
+
+    [Test]
+    public void ExtractTimeOfDayTicksTest()
+    {
+      ExecuteInsideSession(() => {
+        RunTest<SingleDateTimeEntity>(c => c.DateTime.TimeOfDay.Ticks == FirstDateTime.TimeOfDay.Ticks);
+        RunWrongTest<SingleDateTimeEntity>(c => c.DateTime.TimeOfDay.Ticks < FirstDateTime.TimeOfDay.Ticks);
+      });
+    }
   }
 }

Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/DateTimeOffset/PartsExtractionTest.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2016-2021 Xtensive LLC.
+// Copyright (C) 2016-2022 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Alex Groznov
@@ -189,6 +189,18 @@ public void ExtractTimeOfDayWithMillisecondsTest()
       });
     }
 
+    [Test]
+    public void ExtractTimeOfDayTicksTest()
+    {
+      ExecuteInsideSession(() => {
+        var firstDateTimeOffset = TryMoveToLocalTimeZone(FirstDateTimeOffset);
+        RunTest<SingleDateTimeOffsetEntity>(c => c.DateTimeOffset.TimeOfDay.Ticks == firstDateTimeOffset.TimeOfDay.Ticks);
+
+        var wrongDateTimeOffset = TryMoveToLocalTimeZone(WrongDateTimeOffset);
+        RunWrongTest<SingleDateTimeOffsetEntity>(c => c.DateTimeOffset.TimeOfDay.Ticks == wrongDateTimeOffset.TimeOfDay.Ticks);
+      });
+    }
+
     [Test]
     public void ExtractTimeOfDayOfNullableValueTest()
     {