IgnoreRulesHandler supports rules for indexes

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Upgrade/Internals/IgnoreRulesHandler.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2013-2020 Xtensive LLC.
+// Copyright (C) 2013-2020 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Alexey Kulakov
@@ -10,6 +10,7 @@
 using Xtensive.Core;
 using Xtensive.Orm.Configuration;
 using Xtensive.Orm.Providers;
+using Xtensive.Orm.Rse;
 using Xtensive.Sql.Model;
 
 namespace Xtensive.Orm.Upgrade
@@ -31,8 +32,9 @@ public SchemaExtractionResult Handle()
     {
       foreach (var ignoreRule in ignoreRules) {
         var schema = mappingResolver.ResolveSchema(targetModel, ignoreRule.Database, ignoreRule.Schema);
-        if (schema!=null)
+        if (schema != null) {
           VisitSchema(schema, ignoreRule);
+        }
       }
       return targetModel;
     }
@@ -42,59 +44,99 @@ private void VisitSchema(Schema schema, IgnoreRule rule)
       foreignKeysOfSchema = schema.Tables.SelectMany(t => t.TableConstraints.OfType<ForeignKey>()).ToList();
       var matcher = RuleMatcher<Table>.Create(rule.Table);
       var matchedTables = matcher.Get(schema.Tables);
-      if (!MatchingHelper.IsMatchAll(rule.Column))
-        foreach (var table in matchedTables)
+      if (!MatchingHelper.IsMatchAll(rule.Column) || !MatchingHelper.IsMatchAll(rule.Index)) {
+        foreach (var table in matchedTables) {
           VisitTable(table, rule);
-      else
-        foreach (var table in matchedTables)
+        }
+      }
+      else {
+        foreach (var table in matchedTables) {
           RemoveTable(schema.Tables, table);
+        }
+      }
     }
 
     private void VisitTable(Table table, IgnoreRule rule)
     {
-      var matcher = RuleMatcher<TableColumn>.Create(rule.Column);
-      var matchedColumns = matcher.Get(table.TableColumns);
-      foreach (var matchedColumn in matchedColumns)
-        RemoveColumn(table.TableColumns, matchedColumn);
+      var isColumnRule = !string.IsNullOrEmpty(rule.Column);
+      if (isColumnRule) {
+        var matcher = RuleMatcher<TableColumn>.Create(rule.Column);
+        var matchedColumns = matcher.Get(table.TableColumns);
+        foreach (var matchedColumn in matchedColumns) {
+          RemoveColumn(table.TableColumns, matchedColumn);
+        }
+      }
+      else {
+        var matcher = RuleMatcher<Xtensive.Sql.Model.Index>.Create(rule.Index);
+        var matchedIndexes = matcher.Get(table.Indexes);
+        foreach (var matchedIndex in matchedIndexes) {
+          RemoveIndex(table.Indexes, matchedIndex);
+        }
+      }
+      
     }
 
     private void RemoveTable(PairedNodeCollection<Schema, Table> tables, Table tableToRemove)
     {
-      foreach (var foreignKey in foreignKeysOfSchema)
-        if (foreignKey.Owner==tableToRemove || foreignKey.ReferencedTable==tableToRemove) {
-          if (foreignKey.Owner==tableToRemove) {
+      foreach (var foreignKey in foreignKeysOfSchema) {
+        if (foreignKey.Owner == tableToRemove || foreignKey.ReferencedTable == tableToRemove) {
+          if (foreignKey.Owner == tableToRemove) {
             var resolvedTableName = mappingResolver.GetNodeName(foreignKey.ReferencedTable);
-            if (!targetModel.LockedTables.ContainsKey(resolvedTableName))
-              targetModel.LockedTables.Add(resolvedTableName, string.Format(Strings.ExTableXCantBeRemovedDueToForeignKeyYOfIgnoredTableOrColumn, foreignKey.ReferencedTable.Name, foreignKey.Name));
+            if (!targetModel.LockedTables.ContainsKey(resolvedTableName)) {
+              targetModel.LockedTables.Add(resolvedTableName,
+                string.Format(Strings.ExTableXCantBeRemovedDueToForeignKeyYOfIgnoredTableOrColumn,
+                  foreignKey.ReferencedTable.Name, foreignKey.Name));
+            }
           }
-          foreignKey.Owner.TableConstraints.Remove(foreignKey);
+          _ = foreignKey.Owner.TableConstraints.Remove(foreignKey);
         }
-      tables.Remove(tableToRemove);
+      }
+
+      _ = tables.Remove(tableToRemove);
     }
 
     private void RemoveColumn(PairedNodeCollection<Table, TableColumn> columns, TableColumn columnToRemove)
     {
       RemoveForeignKeys(columnToRemove);
       RemoveIndexes(columnToRemove.Table, columnToRemove.Name);
+
       var resolvedTableName = mappingResolver.GetNodeName(columnToRemove.Table);
-      if (!targetModel.LockedTables.ContainsKey(resolvedTableName))
-        targetModel.LockedTables.Add(resolvedTableName, string.Format(Strings.ExTableXCantBeRemovedDueToTheIgnoredColumnY, columnToRemove.Table.Name, columnToRemove.Name));
-      columns.Remove(columnToRemove);
+      if (!targetModel.LockedTables.ContainsKey(resolvedTableName)) {
+        targetModel.LockedTables.Add(resolvedTableName,
+          string.Format(Strings.ExTableXCantBeRemovedDueToTheIgnoredColumnY,
+            columnToRemove.Table.Name, columnToRemove.Name));
+      }
+      _ = columns.Remove(columnToRemove);
+    }
+
+    private void RemoveIndex(PairedNodeCollection<DataTable, Xtensive.Sql.Model.Index> indexes, Xtensive.Sql.Model.Index indexToRemove)
+    {
+      var resolvedTableName = mappingResolver.GetNodeName((Table)indexToRemove.DataTable);
+      if (!targetModel.LockedTables.ContainsKey(resolvedTableName)) {
+        targetModel.LockedTables.Add(resolvedTableName,
+          string.Format(Strings.ExTableXCantBeRemovedDueToTheIgnoredColumnY,
+            ((Table) indexToRemove.DataTable).Name, indexToRemove.Name));
+      }
+      _ = indexes.Remove(indexToRemove);
     }
 
     private void RemoveForeignKeys(TableColumn referencedColumn)
     {
       foreach (var foreignKey in foreignKeysOfSchema) {
-        if (foreignKey.ReferencedColumns.Contains(referencedColumn))
-          foreignKey.Owner.TableConstraints.Remove(foreignKey);
+        if (foreignKey.ReferencedColumns.Contains(referencedColumn)) {
+          _ = foreignKey.Owner.TableConstraints.Remove(foreignKey);
+        }
 
         if (foreignKey.Columns.Contains(referencedColumn)) {
-          if (foreignKey.Owner==referencedColumn.Table) {
+          if (foreignKey.Owner == referencedColumn.Table) {
             var resolvedTableName = mappingResolver.GetNodeName(foreignKey.ReferencedTable);
-            if (!targetModel.LockedTables.ContainsKey(resolvedTableName))
-              targetModel.LockedTables.Add(resolvedTableName, string.Format(Strings.ExTableXCantBeRemovedDueToForeignKeyYOfIgnoredTableOrColumn, foreignKey.ReferencedTable.Name, foreignKey.Name));
+            if (!targetModel.LockedTables.ContainsKey(resolvedTableName)) {
+              targetModel.LockedTables.Add(resolvedTableName,
+                string.Format(Strings.ExTableXCantBeRemovedDueToForeignKeyYOfIgnoredTableOrColumn,
+                  foreignKey.ReferencedTable.Name, foreignKey.Name));
+            }
           }
-          foreignKey.Owner.TableConstraints.Remove(foreignKey);
+          _ = foreignKey.Owner.TableConstraints.Remove(foreignKey);
         }
       }
     }
@@ -104,8 +146,9 @@ private void RemoveIndexes(DataTable table, string columnName)
       var indexes = table.Indexes.Select(index => index)
         .Where(item => item.Columns.Any(column => stringComparer.Equals(column.Name, columnName)))
         .ToList();
-      foreach (var index in indexes)
-        table.Indexes.Remove(index);
+      foreach (var index in indexes) {
+        _ = table.Indexes.Remove(index);
+      }
     }
 
     // Constructors