Invert QueryFeatures item from negative to positive

Author: alex-kulakov

Orm/Xtensive.Orm.Firebird/Sql.Drivers.Firebird/v2_5/ServerInfoProvider.cs

@@ -183,7 +183,6 @@ public override QueryInfo GetQueryInfo()
       queryInfo.Features =
         QueryFeatures.NamedParameters |
         QueryFeatures.ParameterPrefix |
-        QueryFeatures.ParameterAsColumnNotAllowed |
         QueryFeatures.ScalarSubquery |
         QueryFeatures.Paging |
         QueryFeatures.Limit |

Orm/Xtensive.Orm.MySql/Sql.Drivers.MySql/v5_0/ServiceInfoProvider.cs

@@ -209,7 +209,8 @@ public override QueryInfo GetQueryInfo()
         QueryFeatures.ScalarSubquery |
         QueryFeatures.SelfReferencingRowRemovalIsError |
         QueryFeatures.StrictJoinSyntax |
-        QueryFeatures.Batches;
+        QueryFeatures.Batches |
+        QueryFeatures.ParameterAsColumn;
       return queryInfo;
     }
 

Orm/Xtensive.Orm.Oracle/Sql.Drivers.Oracle/v09/ServerInfoProvider.cs

@@ -195,7 +195,8 @@ public override QueryInfo GetQueryInfo()
         QueryFeatures.InsertDefaultValues |
         QueryFeatures.UpdateDefaultValues |
         QueryFeatures.MultischemaQueries |
-        QueryFeatures.RowNumber;
+        QueryFeatures.RowNumber |
+        QueryFeatures.ParameterAsColumn;
       return queryInfo;
     }
 

Orm/Xtensive.Orm.PostgreSql/Sql.Drivers.PostgreSql/v8_0/ServerInfoProvider.cs

@@ -253,7 +253,8 @@ public override QueryInfo GetQueryInfo()
         QueryFeatures.InsertDefaultValues |
         QueryFeatures.UpdateDefaultValues |
         QueryFeatures.MultischemaQueries |
-        QueryFeatures.ScalarSubquery;
+        QueryFeatures.ScalarSubquery |
+        QueryFeatures.ParameterAsColumn;
       info.ParameterPrefix = "@";
       info.MaxComparisonOperations = 1000000;
       info.MaxLength = 1000000;

Orm/Xtensive.Orm.SqlServer/Sql.Drivers.SqlServer/v09/ServerInfoProvider.cs

@@ -201,7 +201,8 @@ public override QueryInfo GetQueryInfo()
         QueryFeatures.MultischemaQueries |
         QueryFeatures.MultidatabaseQueries |
         QueryFeatures.ScalarSubquery |
-        QueryFeatures.PagingRequiresOrderBy;
+        QueryFeatures.PagingRequiresOrderBy |
+        QueryFeatures.ParameterAsColumn;
       return queryInfo;
     }
 

Orm/Xtensive.Orm.Sqlite/Sql.Drivers.Sqlite/v3/ServerInfoProvider.cs

@@ -174,7 +174,8 @@ public override QueryInfo GetQueryInfo()
         | QueryFeatures.Offset
         | QueryFeatures.InsertDefaultValues
         | QueryFeatures.StrictJoinSyntax
-        | QueryFeatures.ScalarSubquery;
+        | QueryFeatures.ScalarSubquery
+        | QueryFeatures.ParameterAsColumn;
       return queryInfo;
     }
 

Orm/Xtensive.Orm.Tests/Upgrade/WeirdSequenceError.cs

@@ -0,0 +1,103 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+using NUnit.Framework;
+using Xtensive.Orm.Model;
+using Before = Xtensive.Orm.Tests.Upgrade.WeirdSequenceErrorModel.Before;
+using After = Xtensive.Orm.Tests.Upgrade.WeirdSequenceErrorModel.After;
+
+namespace Xtensive.Orm.Tests.Upgrade.WeirdSequenceErrorModel
+{
+  namespace Before
+  {
+    [HierarchyRoot(InheritanceSchema.ConcreteTable)]
+    public class VisitDriveTime : Entity
+    {
+      [Key, Field]
+      public long Id { get; set; }
+
+      public VisitDriveTime(Session session) : base(session)
+      {
+      }
+    }
+
+    [TableMapping("VisitDriveTime")]
+    [HierarchyRoot]
+    public class VisitTripInfo : Entity
+    {
+      [Key, Field]
+      public long Id { get; private set; }
+
+      public VisitTripInfo(Session session) : base(session)
+      {
+      }
+    }
+  }
+
+  namespace After
+  {
+    [HierarchyRoot(InheritanceSchema.ConcreteTable)]
+    public class VisitDriveTime : Entity
+    {
+      [Key, Field]
+      public long Id { get; set; }
+
+      public VisitDriveTime(Session session) : base(session)
+      {
+      }
+    }
+
+    [TableMapping("VisitDriveTime")]
+    [HierarchyRoot]
+    //[Index(nameof(Id), Name = "PK_VisitDriveTime")]
+    public class VisitTripInfo : Entity
+    {
+      [Key, Field]
+      public long Id { get; private set; }
+
+      public VisitTripInfo(Session session) : base(session)
+      {
+      }
+    }
+  }
+}
+
+namespace Xtensive.Orm.Tests.Upgrade
+{
+  [TestFixture]
+  public class WeirdSequenceError
+  {
+    [Test]
+    public void OnlyNamespaceChangeTest()
+    {
+      var initConfig = DomainConfigurationFactory.Create();
+      initConfig.Types.Register(typeof(Before.VisitDriveTime));
+      initConfig.UpgradeMode = DomainUpgradeMode.Recreate;
+
+      using (var domain = Domain.Build(initConfig)) { }
+
+      var upgradeConfig = DomainConfigurationFactory.Create();
+      upgradeConfig.Types.Register(typeof(After.VisitDriveTime));
+      upgradeConfig.UpgradeMode = DomainUpgradeMode.Default;
+
+      using (var domain = Domain.Build(upgradeConfig)) { }
+    }
+
+    [Test]
+    public void MainDomainTest()
+    {
+      var initConfig = DomainConfigurationFactory.Create();
+      initConfig.Types.Register(typeof(Before.VisitDriveTime));
+      initConfig.UpgradeMode = DomainUpgradeMode.Recreate;
+
+      using (var domain = Domain.Build(initConfig)) { }
+
+      var upgradeConfig = DomainConfigurationFactory.Create();
+      upgradeConfig.Types.Register(typeof(After.VisitTripInfo));
+      upgradeConfig.UpgradeMode = DomainUpgradeMode.Default;
+
+      using (var domain = Domain.Build(upgradeConfig)) { }
+
+    }
+  }
+}

Orm/Xtensive.Orm/Orm/Providers/SqlCompiler.cs

@@ -565,7 +565,7 @@ public SqlCompiler(HandlerAccessor handlers, CompilerConfiguration configuration
       providerInfo = Handlers.ProviderInfo;
       temporaryTablesSupported = DomainHandler.TemporaryTableManager.Supported;
       forceApplyViaReference = handlers.ProviderInfo.ProviderName.Equals(WellKnown.Provider.PostgreSql);
-      useParameterForTypeId = !Driver.ServerInfo.Query.Features.HasFlag(Sql.Info.QueryFeatures.ParameterAsColumnNotAllowed);
+      useParameterForTypeId = Driver.ServerInfo.Query.Features.HasFlag(Sql.Info.QueryFeatures.ParameterAsColumn);
 
       if (!providerInfo.Supports(ProviderFeatures.FullFeaturedBooleanExpressions)) {
         booleanExpressionConverter = new BooleanExpressionConverter(Driver);

Orm/Xtensive.Orm/Sql/Info/QueryFeatures.cs

@@ -148,9 +148,9 @@ public enum QueryFeatures
     DeleteLimit = 1 << 25,
 
     /// <summary>
-    /// Indicates that RDBMS does not support SQL parameter in selected columns of SELECT statement.
+    /// Indicates that RDBMS supports SQL parameter in selected columns of SELECT statement.
     /// </summary>
-    ParameterAsColumnNotAllowed = 1 << 26,
+    ParameterAsColumn = 1 << 26,
 
     /// <summary>
     /// Indicates that RDBMS supports paging operators (<see cref="Limit"/> and <see cref="Offset"/>).