Introduce dedicated QueryParameterBinding for TypeId

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Providers/CommandProcessing/CommandFactory.cs

@@ -152,6 +152,11 @@ public virtual CommandPart CreateQueryPart(IQueryRequest request, string paramet
           }
           configuration.DynamicFilterValues.Add(binding, filterValues);
           continue;
+          case QueryParameterBindingType.TypeIdentifier: {
+            var originalTypeId = ((QueryTypeIdentifierParameterBinding) binding).OriginalTypeId;
+            parameterValue = Session.StorageNode.TypeIdRegistry[Session.Domain.Model.Types[originalTypeId]];
+            break;
+          }
         default:
           throw new ArgumentOutOfRangeException("binding.BindingType");
         }

Orm/Xtensive.Orm/Orm/Providers/Requests/QueryParameterBindingType.cs

@@ -47,5 +47,10 @@ public enum QueryParameterBindingType
     /// <see cref="ParameterBinding.TypeMapping"/> is ignored in this case.
     /// </summary>
     RowFilter,
+    /// <summary>
+    /// Indicated that parameter is type indentifier.
+    /// <see cref="QueryParameterBinding.ValueAccessor"/> is ignored in this case.
+    /// </summary>
+    TypeIdentifier,
   }
 }

Orm/Xtensive.Orm/Orm/Providers/Requests/QueryTypeIdentifierParameterBinding.cs

@@ -0,0 +1,35 @@
+// Copyright (C) 2022 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
+
+
+using System;
+using Xtensive.Core;
+using Xtensive.Sql;
+
+namespace Xtensive.Orm.Providers
+{
+  /// <summary>
+  /// A special version of <see cref="QueryParameterBinding"/> used for type identifire values within query.
+  /// </summary>
+  public class QueryTypeIdentifierParameterBinding : QueryParameterBinding
+  {
+    private static Func<ParameterContext, object> DummyFactory = (c) => null;
+
+    /// <summary>
+    /// Gets type indentifier of type in Domain model - <see cref="Xtensive.Orm.Model.TypeInfo.TypeId"/>.
+    /// </summary>
+    public int OriginalTypeId { get; private set; }
+
+    /// <summary>
+    /// Creates Instance of this class;
+    /// </summary>
+    /// <param name="originalTypeId">Type indentifier of type in Domain model - <see cref="Xtensive.Orm.Model.TypeInfo.TypeId"/></param>
+    /// <param name="typeMapping">Type mapping for type of type idetifier.</param>
+    public QueryTypeIdentifierParameterBinding(int originalTypeId, TypeMapping typeMapping)
+      : base(typeMapping, DummyFactory, QueryParameterBindingType.TypeIdentifier)
+    {
+      OriginalTypeId = originalTypeId;
+    }
+  }
+}

Orm/Xtensive.Orm/Orm/Providers/SqlCompiler.Index.cs

@@ -41,11 +41,6 @@ public QueryAndBindings(SqlSelect initialQuery, List<QueryParameterBinding> bind
       }
     }
 
-    private static readonly ConcurrentDictionary<int, Func<ParameterContext, object>> typeIdParameterAccessorCache =
-      new ConcurrentDictionary<int, Func<ParameterContext, object>>();
-
-    private static readonly Func<int, Func<ParameterContext, object>> AccessorFactory = typeId => _ => typeId;
-
     private TypeMapping int32TypeMapping;
 
     protected override SqlProvider VisitFreeText(FreeTextProvider provider)
@@ -259,14 +254,14 @@ private QueryAndBindings BuildFilteredQuery(IndexInfo index)
         }
         else {
           if (filterByTypes.Count == 1) {
-            var binding = CreateQueryParameterBinding(type);
+            var binding = CreateTypeIdentifierBinding(type);
             bindings.Add(binding);
             filter = typeIdColumn == binding.ParameterReference;
           }
           else {
             var typeIdParameters = filterByTypes
               .Select(t => {
-                var binding = CreateQueryParameterBinding(t);
+                var binding = CreateTypeIdentifierBinding(t);
                 bindings.Add(binding);
                 return binding.ParameterReference;
               })
@@ -312,7 +307,7 @@ private QueryAndBindings BuildTypedQuery(IndexInfo index)
 
       SqlUserColumn typeIdColumn;
       if (useParameterForTypeId) {
-        var binding = CreateQueryParameterBinding(type);
+        var binding = CreateTypeIdentifierBinding(type);
 
         typeIdColumn = SqlDml.Column(binding.ParameterReference);
         bindings.Add(binding);
@@ -363,11 +358,7 @@ private object GetDiscriminatorValue(TypeDiscriminatorMap discriminatorMap, obje
         : fieldValue;
     }
 
-    private QueryParameterBinding CreateQueryParameterBinding(TypeInfo type) =>
-      new QueryParameterBinding(
-        int32TypeMapping ??= Driver.GetTypeMapping(WellKnownTypes.Int32),
-        typeIdParameterAccessorCache.GetOrAdd(TypeIdRegistry[type], AccessorFactory),
-        QueryParameterBindingType.Regular
-      );
+    private QueryParameterBinding CreateTypeIdentifierBinding(TypeInfo type) =>
+      new QueryTypeIdentifierParameterBinding(type.TypeId, int32TypeMapping ??= Driver.GetTypeMapping(WellKnownTypes.Int32));
   }
 }