Much understandable exeption

Author: alex-kulakov

Orm/Xtensive.Orm.Tests.Sql/MakeNamesUnreadableTest.cs

@@ -366,7 +366,7 @@ private void TestQueryNamesUnreadable(ISqlCompileUnit query, Schema defaultSchem
       if (IsMultidatabaseSupported) {
         var compilerConfiguration = new SqlCompilerConfiguration() { DatabaseQualifiedObjects = true, SharedStorageSchema = true };
 
-        _ = Assert.Throws<ArgumentNullException>(() => queryText = Driver.Compile(query, compilerConfiguration).GetCommandText());
+        _ = Assert.Throws<InvalidOperationException>(() => queryText = Driver.Compile(query, compilerConfiguration).GetCommandText());
 
         var postCompilerConfiguration = new SqlPostCompilerConfiguration(emptyMap, emptyMap);
 
@@ -385,7 +385,7 @@ private void TestQueryNamesUnreadable(ISqlCompileUnit query, Schema defaultSchem
       if (IsMultischemaSupported) {
         var compilerConfiguration = new SqlCompilerConfiguration() { SharedStorageSchema = true };
 
-        _ = Assert.Throws<ArgumentNullException>(() => queryText = Driver.Compile(query, compilerConfiguration).GetCommandText());
+        _ = Assert.Throws<InvalidOperationException>(() => queryText = Driver.Compile(query, compilerConfiguration).GetCommandText());
 
         var postCompilerConfiguration = new SqlPostCompilerConfiguration(emptyMap, emptyMap);
         Assert.DoesNotThrow(() => queryText = Driver.Compile(query, compilerConfiguration).GetCommandText(postCompilerConfiguration));
@@ -402,7 +402,7 @@ private void TestQueryNamesUnreadable(ISqlCompileUnit query, Schema defaultSchem
       }
       else {
         var compilerConfiguration = new SqlCompilerConfiguration() { SharedStorageSchema = true };
-        Assert.DoesNotThrow(() => queryText = Driver.Compile(query, compilerConfiguration).GetCommandText());
+        _ = Assert.Throws<InvalidOperationException>(() => queryText = Driver.Compile(query, compilerConfiguration).GetCommandText());
 
         var postCompilerConfiguration = new SqlPostCompilerConfiguration(emptyMap, emptyMap);
 

Orm/Xtensive.Orm/Sql/Compiler/Internals/PostCompiler.cs

@@ -19,6 +19,7 @@ internal class PostCompiler : NodeVisitor
 
     private readonly StringBuilder result;
     private readonly SqlPostCompilerConfiguration configuration;
+    private readonly bool canActualizeQuery;
 
     private string[] currentCycleItem;
 
@@ -59,6 +60,8 @@ public override void Visit(PlaceholderNode node)
 
     private void Visit(SchemaNodePlaceholderNode node)
     {
+      EnsureActualizationPossible();
+
       var schema = node.SchemaNode.Schema;
 
       var names = (node.DbQualified)
@@ -93,6 +96,12 @@ public override void Visit(CycleNode node)
 
     #endregion
 
+    private void EnsureActualizationPossible()
+    {
+      if (!canActualizeQuery) {
+        throw new InvalidOperationException("Query was compiled with SqlCompilerConfiguration.SharedStorageSchema option set to true, it required PostCompilerConfiguration.SchemaMapping and PostCompilerConfiguration.DatabaseMapping collections to be provided.");
+      }
+    }
 
     // Constructors
 
@@ -101,6 +110,7 @@ private PostCompiler(SqlPostCompilerConfiguration configuration, int estimatedRe
       int capacity = estimatedResultLength + ResultCapacityMargin;
       result = new StringBuilder(capacity < MinimalResultCapacity ? MinimalResultCapacity : capacity);
       this.configuration = configuration;
+      canActualizeQuery = configuration.DatabaseMapping != null && configuration.SchemaMapping != null;
     }
   }
 }