Trigger closure check only if query uses local collections

As I see local collections trigger ItemToTupleConverter to be built and
closure type instance can be captured within ParameterizedQuery.

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Internals/CompiledQueryProcessingScope.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2009-2020 Xtensive LLC.
+// Copyright (C) 2009-2022 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Alexis Kochetov
@@ -19,6 +19,7 @@ internal sealed class CompiledQueryProcessingScope
     public ExtendedExpressionReplacer QueryParameterReplacer { get; }
     public ParameterContext ParameterContext { get; }
     public bool Execute { get; }
+    public bool CheckIfCacheble { get; set; } = false;
 
     [field: ThreadStatic]
     internal static CompiledQueryProcessingScope Current { get; private set; }

Orm/Xtensive.Orm/Orm/Internals/CompiledQueryRunner.cs

@@ -128,7 +128,7 @@ private ParameterizedQuery GetScalarQuery<TResult>(
         throw new NotSupportedException(Strings.ExNonLinqCallsAreNotSupportedWithinQueryExecuteDelayed);
       }
 
-      PutQueryToCacheIfAllowed(parameterizedQuery);
+      PutQueryToCacheIfAllowed(parameterizedQuery, scope.CheckIfCacheble);
 
       return parameterizedQuery;
     }
@@ -149,7 +149,7 @@ private ParameterizedQuery GetSequenceQuery<TElement>(
         parameterizedQuery = (ParameterizedQuery) translatedQuery;
       }
 
-      PutQueryToCacheIfAllowed(parameterizedQuery);
+      PutQueryToCacheIfAllowed(parameterizedQuery, scope.CheckIfCacheble);
 
       return parameterizedQuery;
     }
@@ -266,16 +266,15 @@ private static bool IsTypeCacheable(Type type, IReadOnlySet<Type> supportedTypes
     private ParameterizedQuery GetCachedQuery() =>
       domain.QueryCache.TryGetItem(queryKey, true, out var item) ? item.Second : null;
 
-    private void PutQueryToCacheIfAllowed(ParameterizedQuery parameterizedQuery) {
-      if (IsQueryCacheable()) {
-        domain.QueryCache.Add(new Pair<object, ParameterizedQuery>(queryKey, parameterizedQuery));
-      }
-      else {
+    private void PutQueryToCacheIfAllowed(ParameterizedQuery parameterizedQuery, in bool checkIfCacheable) {
+      if (checkIfCacheable && !IsQueryCacheable()) {
         // no .resx used because it is hot path.
         if (OrmLog.IsLogged(Logging.LogLevel.Info))
           OrmLog.Info("Query can't be cached because closure type it has references to captures reference" +
             " type instances. This will lead to long-living objects in memory.");
+        return;
       }
+      domain.QueryCache.Add(new Pair<object, ParameterizedQuery>(queryKey, parameterizedQuery));
     }
 
     private ParameterContext CreateParameterContext(ParameterizedQuery query)

Orm/Xtensive.Orm/Orm/Linq/Translator.Queryable.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2009-2021 Xtensive LLC.
+// Copyright (C) 2009-2022 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Alexis Kochetov
@@ -1696,6 +1696,7 @@ private ProjectionExpression VisitLocalCollectionSequence<TItem>(Expression sequ
       if (compiledQueryScope != null) {
         var replacer = compiledQueryScope.QueryParameterReplacer;
         var replace = replacer.Replace(sequence);
+        compiledQueryScope.CheckIfCacheble = true;
         var parameter = ParameterAccessorFactory.CreateAccessorExpression<IEnumerable<TItem>>(replace);
         collectionGetter = parameter.CachingCompile();
       }