No RecreateTableHint usage

Author: alex-kulakov

Orm/Xtensive.Orm/Modelling/Comparison/Comparer.cs

@@ -228,10 +228,6 @@ protected virtual MovementInfo BuildMovementInfo(Node source, Node target)
         return movementInfo;
       }
 
-      var recreateHint = Hints.GetHint<RecreateTableHint>(source);
-      if (recreateHint != null) {
-        movementInfo |= MovementInfo.Removed | MovementInfo.Created;// recreated;
-      }
       var sc = StringComparer.OrdinalIgnoreCase;
 
       // both source!=null && target!=null

Orm/Xtensive.Orm/Orm/Upgrade/Internals/HintGenerator.cs

@@ -218,21 +218,21 @@ private void GenerateCopyColumnHint(CopyFieldHint hint)
       }
     }
 
-    private void GenerateRecreateHints(ICollection<StoredTypeInfo> removedTypes)
+    private void GenerateRecreateHints(IList<StoredTypeInfo> removedTypes)
     {
       var capacity = currentModel.Types.Length - typeMapping.Count;
       var newTypes = new Dictionary<string, StoredTypeInfo>(capacity, StringComparer.Ordinal);
       currentNonConnectorTypes
         .Where(t => !reverseTypeMapping.ContainsKey(t))
         .ForEach(t => newTypes.Add($"{t.MappingDatabase}.{t.MappingSchema}.{t.MappingName}", t));
 
-      foreach (var rType in removedTypes) {
+      for (var i = removedTypes.Count - 1; i >= 0; i--) {
+        var rType = removedTypes[i];
         var rTypeIdentifier = $"{rType.MappingDatabase}.{rType.MappingSchema}.{rType.MappingName}";
-        if (!suspiciousTypes.Contains(rType)
-          || !newTypes.TryGetValue(rTypeIdentifier, out var conflictedNewType)) {
-          continue;
+        if (suspiciousTypes.Contains(rType) && newTypes.ContainsKey(rTypeIdentifier)) {
+          schemaHints.Add(new DeleteDataHint(GetTablePath(rType), Array.Empty<IdentityPair>(), true));
+          _ = removedTypes.Remove(rType);
         }
-        schemaHints.Add(new RecreateTableHint(GetTablePath(rType)));
       }
     }