Fixes spelling mistake in FieldInfo public interface (#59)

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Linq/Materialization/ExpressionMaterializer.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2003-2010 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2009-2020 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Alexey Gamzov
 // Created:    2009.05.21
 
@@ -446,7 +446,7 @@ private Expression MaterializeThroughOwner(Expression target, Expression tuple,
         var owner = field.Owner;
         var materializedOwner = MaterializeThroughOwner((Expression) owner, tuple, defaultIfEmpty);
         Expression fieldExpression;
-        if (field.Field.IsDynalicallyDefined) {
+        if (field.Field.IsDynamicallyDefined) {
           var attributes = materializedOwner.Type.GetCustomAttributes(typeof (DefaultMemberAttribute), true);
           var indexerPropertyName = ((DefaultMemberAttribute) attributes.Single()).MemberName;
           var methodInfo = materializedOwner.Type.GetProperty(indexerPropertyName).GetGetMethod();

Orm/Xtensive.Orm/Orm/Linq/QueryHelper.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2003-2010 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2009-2020 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
 // Created:    2009.04.02
 
@@ -83,9 +83,9 @@ public static Expression CreateDirectEntitySetQuery(EntitySetBase entitySet)
       var wrapper = Activator.CreateInstance(
         typeof (OwnerWrapper<>).MakeGenericType(owner.GetType()), owner);
       var wrappedOwner = Expression.Property(Expression.Constant(wrapper), "Owner");
-      if (!entitySet.Field.IsDynalicallyDefined)
+      if (!entitySet.Field.IsDynamicallyDefined) {
         return Expression.Property(wrappedOwner, entitySet.Field.UnderlyingProperty);
-      
+      }
       var indexers = owner.GetType().GetProperties(BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.Public)
         .Where(p => p.GetIndexParameters().Any())
         .Select(p => p.GetGetMethod());
@@ -94,10 +94,12 @@ public static Expression CreateDirectEntitySetQuery(EntitySetBase entitySet)
 
     public static Expression CreateEntitySetQuery(Expression ownerEntity, FieldInfo field)
     {
-      if (!field.IsDynalicallyDefined && !field.UnderlyingProperty.PropertyType.IsOfGenericType(typeof (EntitySet<>)))
+      if (!field.IsDynamicallyDefined && !field.UnderlyingProperty.PropertyType.IsOfGenericType(typeof(EntitySet<>))) {
         throw Exceptions.InternalError(Strings.ExFieldMustBeOfEntitySetType, OrmLog.Instance);
-      if (field.IsDynalicallyDefined && !field.ValueType.IsOfGenericType(typeof (EntitySet<>)))
+      }
+      if (field.IsDynamicallyDefined && !field.ValueType.IsOfGenericType(typeof(EntitySet<>))) {
         throw Exceptions.InternalError(Strings.ExFieldMustBeOfEntitySetType, OrmLog.Instance);
+      }
 
       var elementType = field.ItemType;
       var association = field.Associations.Last();

Orm/Xtensive.Orm/Orm/Linq/Translator.Expressions.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2003-2010 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2009-2020 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Alexis Kochetov
 // Created:    2009.02.27
 
@@ -924,13 +924,16 @@ private IList<Expression> GetStructureFields(
 
       var result = new List<Expression>();
       foreach (PersistentFieldExpression fieldExpression in structureFields) {
-        if (!structureType.GetProperties(BindingFlags.Instance | BindingFlags.Public).Contains(fieldExpression.UnderlyingProperty))
-          if (!context.Model.Types[structureType].Fields[fieldExpression.Name].IsDynalicallyDefined)
+        if (!structureType.GetProperties(BindingFlags.Instance | BindingFlags.Public).Contains(fieldExpression.UnderlyingProperty)) {
+          if (!context.Model.Types[structureType].Fields[fieldExpression.Name].IsDynamicallyDefined) {
             continue;
+          }
+        }
         Type nullableType = fieldExpression.Type.ToNullable();
         Expression propertyAccessorExpression;
-        if (fieldExpression.UnderlyingProperty!=null)
+        if (fieldExpression.UnderlyingProperty!=null) {
           propertyAccessorExpression = Expression.MakeMemberAccess(Expression.Convert(expression, structureType), fieldExpression.UnderlyingProperty);
+        }
         else {
           var attributes = structureType.GetCustomAttributes(typeof(DefaultMemberAttribute), true);
           var indexerPropertyName = ((DefaultMemberAttribute)attributes.Single()).MemberName;
@@ -945,23 +948,23 @@ private IList<Expression> GetStructureFields(
             nullableType));
 
         switch (fieldExpression.GetMemberType()) {
-        case MemberType.Entity:
-          IEnumerable<Type> keyFieldTypes = context
-            .Model
-            .Types[fieldExpression.Type]
-            .Key
-            .TupleDescriptor;
-          result.AddRange(GetEntityFields(memberExpression, keyFieldTypes));
-          break;
-        case MemberType.Structure:
-          var structureFieldExpression = (StructureFieldExpression) fieldExpression;
-          result.AddRange(GetStructureFields(memberExpression, structureFieldExpression.Fields, structureFieldExpression.Type));
-          break;
-        case MemberType.Primitive:
-          result.Add(memberExpression);
-          break;
-        default:
-          throw new NotSupportedException();
+          case MemberType.Entity:
+            IEnumerable<Type> keyFieldTypes = context
+              .Model
+              .Types[fieldExpression.Type]
+              .Key
+              .TupleDescriptor;
+            result.AddRange(GetEntityFields(memberExpression, keyFieldTypes));
+            break;
+          case MemberType.Structure:
+            var structureFieldExpression = (StructureFieldExpression) fieldExpression;
+            result.AddRange(GetStructureFields(memberExpression, structureFieldExpression.Fields, structureFieldExpression.Type));
+            break;
+          case MemberType.Primitive:
+            result.Add(memberExpression);
+            break;
+          default:
+            throw new NotSupportedException();
         }
       }
       return result;

Orm/Xtensive.Orm/Orm/Model/FieldInfo.cs

@@ -661,7 +661,13 @@ public ColumnInfoCollection Columns {
     /// <summary>
     /// Gets a value indicating whether field is dynamically defined.
     /// </summary>
-    public bool IsDynalicallyDefined { get { return UnderlyingProperty==null; } }
+    [Obsolete("Use IsDynamicallyDefined property")]
+    public bool IsDynalicallyDefined => IsDynamicallyDefined;
+
+    /// <summary>
+    /// Gets a value indicating whether field is dynamically defined.
+    /// </summary>
+    public bool IsDynamicallyDefined => UnderlyingProperty == null;
 
     private void GetColumns(ColumnInfoCollection result)
     {

Orm/Xtensive.Orm/Orm/Operations/EntitySetOperation.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2003-2010 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2009-2020 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Alexis Kochetov
 // Created:    2009.11.20
 
@@ -44,7 +44,7 @@ protected EntitySetOperation(Key key, FieldInfo field)
     {
       Type fieldType;
       string fieldName = string.Empty;
-      if (field.IsDynalicallyDefined) {
+      if (field.IsDynamicallyDefined) {
         fieldType = field.ValueType;
         var name = field.Name;
       }