Faster way to detect whether type is Nullable

alex-kulakov · alex-kulakov · commit b667edcab924 · 2020-11-13T19:20:09.000+05:00
diff --git a/Orm/Xtensive.Orm/Orm/Linq/Translator.Expressions.cs b/Orm/Xtensive.Orm/Orm/Linq/Translator.Expressions.cs
@@ -1321,7 +1321,7 @@ bool propertyFilter(PersistentFieldExpression f)
         if (isMarker && ((markerType & MarkerType.Single) == MarkerType.Single)) {
           throw new InvalidOperationException(string.Format(Strings.ExUseMethodXOnFirstInsteadOfSingle, sourceExpression.ToString(true), member.Name));
         }
-        if (member.DeclaringType.IsGenericType && member.DeclaringType.GetGenericTypeDefinition() == typeof(Nullable<>)) {
+        if (TypeHelper.IsNullable(member.DeclaringType)) {
           expression = Expression.Convert(expression, member.DeclaringType);
         }
         return Expression.MakeMemberAccess(expression, member);

Original file line number	Diff line number	Diff line change
`@@ -1321,7 +1321,7 @@ bool propertyFilter(PersistentFieldExpression f)`
`1321`	`1321`	`if (isMarker && ((markerType & MarkerType.Single) == MarkerType.Single)) {`
`1322`	`1322`	`throw new InvalidOperationException(string.Format(Strings.ExUseMethodXOnFirstInsteadOfSingle, sourceExpression.ToString(true), member.Name));`
`1323`	`1323`	`}`
`1324`		`- if (member.DeclaringType.IsGenericType && member.DeclaringType.GetGenericTypeDefinition() == typeof(Nullable<>)) {`
	`1324`	`+ if (TypeHelper.IsNullable(member.DeclaringType)) {`
`1325`	`1325`	`expression = Expression.Convert(expression, member.DeclaringType);`
`1326`	`1326`	`}`
`1327`	`1327`	`return Expression.MakeMemberAccess(expression, member);`