Forbids to use Session.SelectStorageNode for sessions with opened connection

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Providers/StorageDriver.Operations.cs

@@ -23,11 +23,17 @@ private sealed class InitializationSqlExtension
 
     public void ApplyNodeConfiguration(SqlConnection connection, NodeConfiguration nodeConfiguration)
     {
-      if (nodeConfiguration.ConnectionInfo!=null)
+      if (connection.State != ConnectionState.Closed) {
+        throw new InvalidOperationException(Strings.ExCannotApplyNodeConfigurationSettingsConnectionIsInUse);
+      }
+
+      if (nodeConfiguration.ConnectionInfo != null) {
         connection.ConnectionInfo = nodeConfiguration.ConnectionInfo;
+      }
 
-      if (!string.IsNullOrEmpty(nodeConfiguration.ConnectionInitializationSql))
+      if (!string.IsNullOrEmpty(nodeConfiguration.ConnectionInitializationSql)) {
         SetInitializationSql(connection, nodeConfiguration.ConnectionInitializationSql);
+      }
     }
 
     public SqlConnection CreateConnection(Session session)

Orm/Xtensive.Orm/Strings.Designer.cs

@@ -3446,4 +3446,7 @@ Error: {1}</value>
   <data name="ExKeyBelongsToDifferentStorageNode" xml:space="preserve">
     <value>The Key belongs to different storage node.</value>
   </data>
+  <data name="ExCannotApplyNodeConfigurationSettingsConnectionIsInUse" xml:space="preserve">
+    <value>Cannot apply node configuration: connection is already in use. This may happen if the session was open asynchronously. Use new StorageNode.OpenSession(...) API instead of Session.SelectStorageNode(...)</value>
+  </data>
 </root>