Resolve warnings

HashingAlgorithms left as they were because suggested by the dotnet .Create()
is inefficient and with bugs.

Author: alex-kulakov

Extensions/Xtensive.Orm.Security/Cryptography/GenericHashingService.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2011 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2011-2022 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2011.06.10
 
@@ -31,14 +31,7 @@ public abstract class GenericHashingService : IHashingService
     /// Gets the salt.
     /// </summary>
     /// <returns>The salt.</returns>
-    protected byte[] GetSalt()
-    {
-      var salt = new byte[SaltSize];
-      using (var rng = new RNGCryptoServiceProvider()) {
-        rng.GetBytes(salt);
-        return salt;
-      }
-    }
+    protected byte[] GetSalt() => RandomNumberGenerator.GetBytes(SaltSize);
 
     /// <summary>
     /// Computes the hash.

Extensions/Xtensive.Orm.Security/Cryptography/MD5HashingService.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2011 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2011-2022 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2011.05.22
 
@@ -17,10 +17,10 @@ namespace Xtensive.Orm.Security.Cryptography
   public class MD5HashingService : GenericHashingService
   {
     /// <inheritdoc/>
-    protected override HashAlgorithm GetHashAlgorithm()
-    {
-      return new MD5CryptoServiceProvider();
-    }
+#pragma warning disable SYSLIB0021 // Type or member is obsolete
+    // direct creation is more efficient than MD5.Create()
+    protected override HashAlgorithm GetHashAlgorithm() => new MD5CryptoServiceProvider();
+#pragma warning restore SYSLIB0021 // Type or member is obsolete
 
     /// <summary>
     /// Initializes a new instance of the <see cref="MD5HashingService"/> class.

Extensions/Xtensive.Orm.Security/Cryptography/SHA1HashingService.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2011 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2011-2022 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2011.05.22
 
@@ -16,10 +16,10 @@ namespace Xtensive.Orm.Security.Cryptography
   public class SHA1HashingService : GenericHashingService
   {
     /// <inheritdoc/>
-    protected override HashAlgorithm GetHashAlgorithm()
-    {
-      return new SHA1Managed();
-    }
+#pragma warning disable SYSLIB0021 // Type or member is obsolete
+    // direct creation is more efficient than SHA1.Create()
+    protected override HashAlgorithm GetHashAlgorithm() => new SHA1Managed();
+#pragma warning restore SYSLIB0021 // Type or member is obsolete
 
     /// <summary>
     /// Initializes a new instance of the <see cref="SHA1HashingService"/> class.

Extensions/Xtensive.Orm.Security/Cryptography/SHA256HashingService.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2011 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2011-2022 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2011.05.22
 
@@ -16,10 +16,10 @@ namespace Xtensive.Orm.Security.Cryptography
   public class SHA256HashingService : GenericHashingService
   {
     /// <inheritdoc/>
-    protected override HashAlgorithm GetHashAlgorithm()
-    {
-      return new SHA256Managed();
-    }
+#pragma warning disable SYSLIB0021 // Type or member is obsolete
+    // direct creation is more efficient than SHA256.Create()
+    protected override HashAlgorithm GetHashAlgorithm() => new SHA256Managed();
+#pragma warning restore SYSLIB0021 // Type or member is obsolete
 
     /// <summary>
     /// Initializes a new instance of the <see cref="SHA256HashingService"/> class.

Extensions/Xtensive.Orm.Security/Cryptography/SHA384HashingService.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2011 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2011-2022 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2011.05.22
 
@@ -16,10 +16,10 @@ namespace Xtensive.Orm.Security.Cryptography
   public class SHA384HashingService : GenericHashingService
   {
     /// <inheritdoc/>
-    protected override HashAlgorithm GetHashAlgorithm()
-    {
-      return new SHA384Managed();
-    }
+#pragma warning disable SYSLIB0021 // Type or member is obsolete
+    // direct creation is more efficient than SHA384.Create()
+    protected override HashAlgorithm GetHashAlgorithm() => new SHA384Managed();
+#pragma warning restore SYSLIB0021 // Type or member is obsolete
 
     /// <summary>
     /// Initializes a new instance of the <see cref="SHA384HashingService"/> class.

Extensions/Xtensive.Orm.Security/Cryptography/SHA512HashingService.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2011 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2011-2022 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2011.05.22
 
@@ -16,10 +16,10 @@ namespace Xtensive.Orm.Security.Cryptography
   public class SHA512HashingService : GenericHashingService
   {
     /// <inheritdoc/>
-    protected override HashAlgorithm GetHashAlgorithm()
-    {
-      return new SHA512Managed();
-    }
+#pragma warning disable SYSLIB0021 // Type or member is obsolete
+    // direct creation is more efficient than SHA512.Create()
+    protected override HashAlgorithm GetHashAlgorithm() => new SHA512Managed();
+#pragma warning restore SYSLIB0021 // Type or member is obsolete
 
     /// <summary>
     /// Initializes a new instance of the <see cref="SHA512HashingService"/> class.

Orm/Xtensive.Orm.Sqlite/Sql.Drivers.Sqlite/ProviderInitializer.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2012 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2012-2022 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
 // Created:    2012.08.21
 
@@ -53,13 +53,17 @@ private static Stream GetLibraryStream()
 
     private static string GetLibraryHash()
     {
-      using (var hashProvider = new SHA1Managed()) {
-        hashProvider.Initialize();
-        using (var stream = GetLibraryStream())
-          hashProvider.ComputeHash(stream);
-        var hash = hashProvider.Hash.Take(8).ToArray();
-        return new StringBuilder().AppendHexArray(hash).ToString();
+#pragma warning disable SYSLIB0021 // Type or member is obsolete
+      // direct creation is more efficient than SHA1.Create()
+      using (var hashProvider = new System.Security.Cryptography.SHA1Managed()) {
+        //hashProvider.Initialize();
+        ReadOnlySpan<byte> hashRaw;
+        using (var stream = GetLibraryStream()) {
+          hashRaw = hashProvider.ComputeHash(stream);
+        }
+        return new StringBuilder().AppendHexArray(hashRaw[..8]).ToString();
       }
+#pragma warning restore SYSLIB0021 // Type or member is obsolete
     }
 
     private static string GetLibraryFileName(string nativeLibraryCacheFolder, string moduleHash)

Orm/Xtensive.Orm.Tests/Storage/Randomized/RandomizedTest.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2003-2010 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2009-2022 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Alexander Nikolaev
 // Created:    2009.11.26
 
@@ -28,6 +28,7 @@ public sealed class RandomizedTest : AutoBuildTest
     private Random randomProvider;
     private bool isSettingUp;
     private readonly List<Key> entitySetCache = new List<Key>();
+
     protected override DomainConfiguration BuildConfiguration()
     {
       var config = base.BuildConfiguration();
@@ -265,8 +266,9 @@ private void ThrowOrCompleteTransaction(TransactionScope tx)
 
     private static int GetSeed()
     {
-      var bytes = new byte[sizeof (int)];
-      var seedProvider = new RNGCryptoServiceProvider();
+      var bytes = new byte[sizeof(int)];
+
+      using var seedProvider = RandomNumberGenerator.Create();
       seedProvider.GetNonZeroBytes(bytes);
       return BitConverter.ToInt32(bytes, 0);
     }

Orm/Xtensive.Orm/Core/Extensions/StringBuilderExtensions.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2003-2010 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2008-2022 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Alex Kofman
 // Created:    2008.07.30
 
@@ -81,7 +81,27 @@ public static StringBuilder AppendHexArray(this StringBuilder builder, byte[] va
 
       const string lowerHexChars = "0123456789abcdef";
       foreach (var item in values) {
-        builder.Append(lowerHexChars[item >> 4])
+        _ = builder.Append(lowerHexChars[item >> 4])
+          .Append(lowerHexChars[item & 0xF]);
+      }
+      return builder;
+    }
+
+    /// <summary>
+    /// Appends the specified <see cref="byte"/> array in hexidecimal representation in lower case.
+    /// These bytes are written from left to right, high part of byte is written first.
+    /// For example {1,2,10} will be appended as 01020a.
+    /// </summary>
+    /// <param name="builder">The builder.</param>
+    /// <param name="values">The values.</param>
+    /// <returns>Original <paramref name="builder"/>.</returns>
+    public static StringBuilder AppendHexArray(this StringBuilder builder, in ReadOnlySpan<byte> values)
+    {
+      ArgumentValidator.EnsureArgumentNotNull(builder, "builder");
+
+      const string lowerHexChars = "0123456789abcdef";
+      foreach (var item in values) {
+        _ = builder.Append(lowerHexChars[item >> 4])
           .Append(lowerHexChars[item & 0xF]);
       }
       return builder;

Orm/Xtensive.Orm/Orm/Providers/NameBuilder.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2007-2020 Xtensive LLC.
+// Copyright (C) 2007-2022 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
@@ -577,10 +577,12 @@ public string ApplyNamingRules(string name)
     /// <returns>Computed hash.</returns>
     private static string GetHash(string name)
     {
+#pragma warning disable SYSLIB0021 // Type or member is obsolete
       using (var hashAlgorithm = new MD5CryptoServiceProvider()) {
-        byte[] hash = hashAlgorithm.ComputeHash(Encoding.UTF8.GetBytes(name));
+        var hash = hashAlgorithm.ComputeHash(Encoding.UTF8.GetBytes(name));
         return $"H{hash[0]:x2}{hash[1]:x2}{hash[2]:x2}{hash[3]:x2}";
       }
+#pragma warning restore SYSLIB0021 // Type or member is obsolete
     }
 
     private static string FormatKeyGeneratorName(string database, string name)