SessionBound registry improvements

- different error message
- method of disabling changes renamed

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Internals/ChangeRegistries/SessionBoundRegistry.cs

@@ -1,7 +1,7 @@
-// Copyright (C) 2022 Xtensive LLC.
+// Copyright (C) 2022-2025 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
-// Created by: Dmitri Maximov
+// Created by: Alexey Kulakov
 // Created:    2022.06.14
 
 using System;
@@ -16,7 +16,7 @@ public abstract class SessionBoundRegistry : SessionBound
   {
     private bool changesDisabled;
 
-    internal Core.Disposable PreventChanges()
+    internal Core.Disposable DisableRegistrations()
     {
       changesDisabled = true;
       return new Core.Disposable((a) => changesDisabled = false);
@@ -26,7 +26,7 @@ protected void EnsureRegistrationsAllowed()
     {
       if (changesDisabled) {
         throw new InvalidOperationException(
-          string.Format(Strings.ExSessionXIsActivelyPersistingChangesNoPersistentChangesAllowed, Session.Guid));
+          string.Format(Strings.ExPersistentChangesAreNotAllowedForThisEvent, Session.Guid));
       }
     }
 

Orm/Xtensive.Orm/Orm/Session.Persist.cs

@@ -376,12 +376,12 @@ private void ProcessChangesOfEntitySets(Action<EntitySetState> action)
         action.Invoke(entitySet);
     }
 
-    private IDisposable PreventRegistryChanges()
+    private JoiningDisposable PreventRegistryChanges()
     {
-      return EntityChangeRegistry.PreventChanges()
-        & EntitySetChangeRegistry.PreventChanges()
-        & NonPairedReferencesRegistry.PreventChanges()
-        & ReferenceFieldsChangesRegistry.PreventChanges();
+      return EntityChangeRegistry.DisableRegistrations()
+        & EntitySetChangeRegistry.DisableRegistrations()
+        & NonPairedReferencesRegistry.DisableRegistrations()
+        & ReferenceFieldsChangesRegistry.DisableRegistrations();
     }
   }
 }

Orm/Xtensive.Orm/Strings.Designer.cs

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!-- 
     Microsoft ResX Schema 
@@ -2618,7 +2618,7 @@ Error: {1}</value>
   <data name="LogKeyGeneratorKindForHierarchyWithRootXHasChangedToNone" xml:space="preserve">
     <value>Key generator kind for hierarchy with root '{0}' has changed to None. Make sure that all key values are recieved by constructor and passed to one of Entity constructors.</value>
   </data>
-  <data name="ExSessionXIsActivelyPersistingChangesNoPersistentChangesAllowed" xml:space="preserve">
-    <value>Session '{0}' is actively persisting changes, persistent objects' changes are not allowed.</value>
+  <data name="ExPersistentChangesAreNotAllowedForThisEvent" xml:space="preserve">
+    <value>Changes of persistent objects are not allowed for this event due to possibility of changes not reaching database. Try use Session.Events.Persisting or Session.Events.TransactionPreCommitting for such changes for them to be saved correctly.</value>
   </data>
 </root>