From 4d6d9cb36cf562007201d906383f3a23cc8e0901 Mon Sep 17 00:00:00 2001 From: DanCodedThis Date: Fri, 26 Dec 2025 15:44:13 +0200 Subject: [PATCH 1/6] fix --- crates/embucket-lambda/Makefile | 2 +- crates/embucket-lambda/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/embucket-lambda/Makefile b/crates/embucket-lambda/Makefile index c164bdeb..3688c73e 100644 --- a/crates/embucket-lambda/Makefile +++ b/crates/embucket-lambda/Makefile @@ -17,7 +17,7 @@ deploy: build deploy-only public-url # Quick deploy without rebuild deploy-only: - cd ../.. && cargo lambda deploy $(OTEL_COLLECTOR_LAYERS) --iam-role $(IAM_ROLE) --env-file $(ENV_FILE) --binary-name bootstrap $(FUNCTION_NAME) + cd ../.. && cargo lambda deploy $(OTEL_COLLECTOR_LAYERS) $(IAM_ROLE) --env-file $(ENV_FILE) --binary-name bootstrap $(FUNCTION_NAME) aws logs create-log-group --log-group-name "/aws/lambda/$(FUNCTION_NAME)" >/dev/null 2>&1 || true public-url: diff --git a/crates/embucket-lambda/README.md b/crates/embucket-lambda/README.md index 063eda07..586f828f 100644 --- a/crates/embucket-lambda/README.md +++ b/crates/embucket-lambda/README.md @@ -63,7 +63,7 @@ cargo lambda deploy --binary-name bootstrap 3. Environment variable: `export CARGO_LAMBDA_FUNCTION_NAME=my-function` (if supported by your cargo-lambda version) **IAM Role**: Only needed when creating a NEW function. For existing functions, the role is preserved. -- To specify: `export AWS_LAMBDA_ROLE_ARN=arn:aws:iam::account:role/YourRole` +- To specify: `export IAM_ROLE=--iam-role arn:aws:iam::account:role/YourRole` **Other Settings** (in `Cargo.toml`): - Memory: `memory = 3008` From 6d563124e66e5e90d9d6f914518f15a6978340d8 Mon Sep 17 00:00:00 2001 From: DanCodedThis Date: Fri, 26 Dec 2025 16:01:34 +0200 Subject: [PATCH 2/6] requested changes --- crates/embucket-lambda/Cargo.toml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/crates/embucket-lambda/Cargo.toml b/crates/embucket-lambda/Cargo.toml index 72f1d4dc..866accbe 100644 --- a/crates/embucket-lambda/Cargo.toml +++ b/crates/embucket-lambda/Cargo.toml @@ -51,12 +51,6 @@ state-store-query = ["executor/state-store-query"] # Default binary to deploy default-binary = "bootstrap" -[package.metadata.lambda.deploy] -# Function name: Can be set via CARGO_LAMBDA_FUNCTION_NAME env var -# If not set, falls back to binary name or pass as CLI argument -memory = 3008 -timeout = 30 -tracing = "Active" # Note: include path is relative to workspace root # Must run deploy from workspace root: cargo lambda deploy --binary-name bootstrap include = ["config"] From 3e547a76b937df1e44f41cae1d3560c48b6158c0 Mon Sep 17 00:00:00 2001 From: DanCodedThis Date: Fri, 26 Dec 2025 16:03:34 +0200 Subject: [PATCH 3/6] requested changes --- crates/embucket-lambda/Makefile | 2 +- crates/embucket-lambda/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/embucket-lambda/Makefile b/crates/embucket-lambda/Makefile index 3688c73e..adcb9e54 100644 --- a/crates/embucket-lambda/Makefile +++ b/crates/embucket-lambda/Makefile @@ -3,7 +3,7 @@ # Function name (override with: make deploy FUNCTION_NAME=your-function) FUNCTION_NAME ?= embucket-lambda ENV_FILE ?= config/.env -IAM_ROLE ?= +AWS_LAMBDA_ROLE_ARN := $(if $(AWS_LAMBDA_ROLE_ARN),--features $(AWS_LAMBDA_ROLE_ARN)) OTEL_COLLECTOR_LAYERS ?= # supported features: "streaming" FEATURES_PARAM := $(if $(FEATURES),--features $(FEATURES)) diff --git a/crates/embucket-lambda/README.md b/crates/embucket-lambda/README.md index 586f828f..063eda07 100644 --- a/crates/embucket-lambda/README.md +++ b/crates/embucket-lambda/README.md @@ -63,7 +63,7 @@ cargo lambda deploy --binary-name bootstrap 3. Environment variable: `export CARGO_LAMBDA_FUNCTION_NAME=my-function` (if supported by your cargo-lambda version) **IAM Role**: Only needed when creating a NEW function. For existing functions, the role is preserved. -- To specify: `export IAM_ROLE=--iam-role arn:aws:iam::account:role/YourRole` +- To specify: `export AWS_LAMBDA_ROLE_ARN=arn:aws:iam::account:role/YourRole` **Other Settings** (in `Cargo.toml`): - Memory: `memory = 3008` From 970b121c7e6f0f9374f0984d60ae1d2aedcd296e Mon Sep 17 00:00:00 2001 From: DanCodedThis Date: Fri, 26 Dec 2025 16:04:24 +0200 Subject: [PATCH 4/6] fix --- crates/embucket-lambda/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/embucket-lambda/Makefile b/crates/embucket-lambda/Makefile index adcb9e54..cabcb5f2 100644 --- a/crates/embucket-lambda/Makefile +++ b/crates/embucket-lambda/Makefile @@ -3,7 +3,7 @@ # Function name (override with: make deploy FUNCTION_NAME=your-function) FUNCTION_NAME ?= embucket-lambda ENV_FILE ?= config/.env -AWS_LAMBDA_ROLE_ARN := $(if $(AWS_LAMBDA_ROLE_ARN),--features $(AWS_LAMBDA_ROLE_ARN)) +AWS_LAMBDA_ROLE_ARN := $(if $(AWS_LAMBDA_ROLE_ARN),--iam-role $(AWS_LAMBDA_ROLE_ARN)) OTEL_COLLECTOR_LAYERS ?= # supported features: "streaming" FEATURES_PARAM := $(if $(FEATURES),--features $(FEATURES)) From 5859cb619cbc4dc22f6379ffd0e7dfa80863ceba Mon Sep 17 00:00:00 2001 From: DanCodedThis Date: Fri, 26 Dec 2025 16:05:55 +0200 Subject: [PATCH 5/6] layer-arn --- crates/embucket-lambda/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/embucket-lambda/Makefile b/crates/embucket-lambda/Makefile index cabcb5f2..15491a28 100644 --- a/crates/embucket-lambda/Makefile +++ b/crates/embucket-lambda/Makefile @@ -4,7 +4,7 @@ FUNCTION_NAME ?= embucket-lambda ENV_FILE ?= config/.env AWS_LAMBDA_ROLE_ARN := $(if $(AWS_LAMBDA_ROLE_ARN),--iam-role $(AWS_LAMBDA_ROLE_ARN)) -OTEL_COLLECTOR_LAYERS ?= +OTEL_COLLECTOR_LAYERS ?= $(if $(OTEL_COLLECTOR_LAYERS),--layer-arn $(OTEL_COLLECTOR_LAYERS)) # supported features: "streaming" FEATURES_PARAM := $(if $(FEATURES),--features $(FEATURES)) From 081f8bf2b27d01d0d44d526a835b6514e25ae28d Mon Sep 17 00:00:00 2001 From: DanCodedThis Date: Fri, 26 Dec 2025 16:35:09 +0200 Subject: [PATCH 6/6] requested changes --- crates/embucket-lambda/Cargo.toml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/crates/embucket-lambda/Cargo.toml b/crates/embucket-lambda/Cargo.toml index 866accbe..861856c2 100644 --- a/crates/embucket-lambda/Cargo.toml +++ b/crates/embucket-lambda/Cargo.toml @@ -51,10 +51,12 @@ state-store-query = ["executor/state-store-query"] # Default binary to deploy default-binary = "bootstrap" +[package.metadata.lambda.deploy] +# Function name: Can be set via CARGO_LAMBDA_FUNCTION_NAME env var +# If not set, falls back to binary name or pass as CLI argument +memory = 3008 +timeout = 30 +tracing = "Active" # Note: include path is relative to workspace root # Must run deploy from workspace root: cargo lambda deploy --binary-name bootstrap include = ["config"] - -[package.metadata.lambda.deploy.env] -LOG_FORMAT = "json" -METASTORE_CONFIG = "config/metastore.yaml"