-
-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Preflight Checklist
- I have read the Contributing Guidelines for this project, if it exists.
- I agree to follow the Code of Conduct that this project adheres to.
- I have searched the issue tracker for a feature request that matches the one I want to file, without success.
Problem Description
Currently, some of our migrations that modify schema are non-deterministic. I.e. they have different results depending on the environment they are run in.
Two examples of that are
- Using
configobject to create tables in Laravel Permissions - Using
if (Schema::connection('tenant')->hasTable(....))
This has various downsides. For example it prevents ever changing the value of config that is used in the migration. Also, can produce inconsistencies when migrations are silently not running or running twice.
Proposed Solution
Please change all migration that modify schema to be deterministic. I.e. have a reproducible output.
- Remove all
if (Schema::connection('tenant')->hasTable(....))constructs - Hardcode any values that are currently read from config.
Alternatives Considered
N/A
Additional Information
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request