Skip to content

[Bug] version-check returns changed: false even if the change was correctly identified in 2.1.6 #315

@guillaume-docquier-vention

Description

Describe the bug
The action identifies my change, but returns changed: false when it used to say changed: true

To Reproduce

  • Bumped my package.json version
  • Commit and push
  • The action runs, identifies the bump, but gives changed: false

Expected behavior
changed should be true

Screenshots

Run EndBug/version-check@v2
  with:
    diff-search: true
    file-name: <REDACTED>
    token: ***
    github-api-url: https://api.github.com/
  env:
    project-path: <REDACTED>
Searching for version update...
Searching in 1 commit...
  Package file name: "<REDACTED>/package.json"
  Package file URL: undefined
  Version assumptions: undefined
No standard npm version commit found, switching to diff search (this could take more time...)
Checking the diffs of 1 commit...
  - e6fd300: match found, more info below
Found match for version 0.6.1: <REDACTED> - <REDACTED>
Outputs:
  version: 0.6.1
  type: patch
  commit: <REDACTED>
  changed: false

Additional context
Seems to be this: debee80#diff-4fab5baaca5c14d2de62d8d2fceef376ddddcc8e9509d86cfa5643f51b89ce3dL383

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomerstype: bugVerified problems that need to be worked on

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions