From 6c809def6ac5842c0a1d62a4b23d533d0d74b55a Mon Sep 17 00:00:00 2001 From: Paola De Bartolo Date: Mon, 11 Nov 2024 14:26:57 -0300 Subject: [PATCH 1/2] docs: fix Javdoc warnings Close #28 --- .../vaadin/addons/chatassistant/ChatAssistant.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java b/src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java index 30b2881..2afbcba 100644 --- a/src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java +++ b/src/main/java/com/flowingcode/vaadin/addons/chatassistant/ChatAssistant.java @@ -318,13 +318,13 @@ public Component getFooterComponent() { } /** - * Scrolls to the given row index. Scrolls so that the element is shown at + * Scrolls to the given position. Scrolls so that the element is shown at * the start of the visible area whenever possible. *

* If the index parameter exceeds current item set size the grid will scroll * to the end. * - * @param rowIndex + * @param position * zero based index of the item to scroll to in the current view. */ public void scrollToIndex(int position) { From d799cf2a1a8052fd1105f5b143145923c4295f9b Mon Sep 17 00:00:00 2001 From: Paola De Bartolo Date: Mon, 11 Nov 2024 14:27:42 -0300 Subject: [PATCH 2/2] ci: configure Javadoc failOnWarnings Close #30 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 4b83eb0..c0be038 100644 --- a/pom.xml +++ b/pom.xml @@ -314,7 +314,7 @@ true none - false + true https://javadoc.io/doc/com.vaadin/vaadin-platform-javadoc/${vaadin.version}