From eaf287cbaa4f5de796f5b46b12fce799b4384712 Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Wed, 6 Nov 2024 15:02:15 -0300 Subject: [PATCH 1/2] docs: fix javadoc --- .../addons/enhancedtabs/EnhancedTabs.java | 28 +++++++++++-------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/src/main/java/com/flowingcode/vaadin/addons/enhancedtabs/EnhancedTabs.java b/src/main/java/com/flowingcode/vaadin/addons/enhancedtabs/EnhancedTabs.java index e3facb5..1915b4e 100644 --- a/src/main/java/com/flowingcode/vaadin/addons/enhancedtabs/EnhancedTabs.java +++ b/src/main/java/com/flowingcode/vaadin/addons/enhancedtabs/EnhancedTabs.java @@ -47,6 +47,7 @@ import com.vaadin.flow.component.dependency.JsModule; import com.vaadin.flow.component.menubar.MenuBar; import com.vaadin.flow.component.tabs.Tab; +import com.vaadin.flow.component.tabs.Tabs; import com.vaadin.flow.router.RouterLink; import com.vaadin.flow.shared.Registration; import java.io.Serializable; @@ -65,15 +66,17 @@ * Tabs when you want to allow in-place navigation within a certain part of the UI, instead of * showing everything at once or forcing the user to navigate between different views. * - *
{@link Tab} components can be added to this component with the {@link #add(Tab...)} method or - * the {@link #Tabs(Tab...)} constructor. The Tab components added to it can be selected with the - * {@link #setSelectedIndex(int)} or {@link #setSelectedTab(Tab)} methods. The first added {@link - * Tab} component will be automatically selected, firing a {@link SelectedChangeEvent}, unless - * autoselection is explicitly disabled with {@link #Tabs(boolean, Tab...)}, or {@link - * #setAutoselect(boolean)}. Removing the selected tab from the component changes the selection to - * the next available tab. + *
+ * {@link Tab} components can be added to this component with the {@link #add(Tab...)} method or the + * {@link Tabs#Tabs(Tab...)} constructor. The Tab components added to it can be selected with the + * {@link #setSelectedIndex(int)} or {@link #setSelectedTab(Tab)} methods. The first added + * {@link Tab} component will be automatically selected, firing a {@link SelectedChangeEvent}, + * unless autoselection is explicitly disabled with {@link Tabs#Tabs(boolean, Tab...)}, or + * {@link #setAutoselect(boolean)}. Removing the selected tab from the component changes the + * selection to the next available tab. * - *
Note: Adding or removing Tab components via the Element API, eg. {@code + *
+ * Note: Adding or removing Tab components via the Element API, eg. {@code * tabs.getElement().insertChild(0, tab.getElement()); }, doesn't update the selected index, so it * may cause the selected tab to change unexpectedly. */ @@ -160,10 +163,11 @@ public EnhancedTabs(boolean autoselect, Tab... tabs) { /** * Adds the given tabs to the component. * - *
The first added {@link Tab} component will be automatically selected, unless auto-selection - * is explicitly disabled with {@link #Tabs(boolean, Tab...)}, or {@link #setAutoselect(boolean)}. - * If a selection change listener has been added before adding the tabs, it will be notified with - * the auto-selected tab. + *
+ * The first added {@link Tab} component will be automatically selected, unless auto-selection is
+ * explicitly disabled with {@link Tabs#Tabs(boolean, Tab...)}, or
+ * {@link #setAutoselect(boolean)}. If a selection change listener has been added before adding
+ * the tabs, it will be notified with the auto-selected tab.
*
* @param tabs the tabs to enclose
*/
From 6b4f03cdc8705189087cd14172a6df6bf87fd3c0 Mon Sep 17 00:00:00 2001
From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com>
Date: Wed, 6 Nov 2024 15:02:26 -0300
Subject: [PATCH 2/2] build: upgrade javadoc plugin to 3.11.1
---
pom.xml | 41 ++++++++++++++++++++++-------------------
1 file changed, 22 insertions(+), 19 deletions(-)
diff --git a/pom.xml b/pom.xml
index cdff5f5..ff00098 100644
--- a/pom.xml
+++ b/pom.xml
@@ -306,25 +306,28 @@
-