From 59ad5d404fd33e2a02d0a28d178c8c63d7d409a9 Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Tue, 23 Dec 2025 11:56:40 -0300 Subject: [PATCH 1/3] ci: add vaadin-dev dependency to v25 profile --- pom.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pom.xml b/pom.xml index af05cb5..174b899 100644 --- a/pom.xml +++ b/pom.xml @@ -550,6 +550,11 @@ 5.0.0 test + + com.vaadin + vaadin-dev + true + From 2be330bf4c8e59a35fe616b3526ee30e992eb6fc Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Tue, 23 Dec 2025 11:56:59 -0300 Subject: [PATCH 2/3] ci: upgrade to vaadin 25.0.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 174b899..5387e4a 100644 --- a/pom.xml +++ b/pom.xml @@ -540,7 +540,7 @@ 21 21 - 25.0.0-beta2 + 25.0.0 11.0.26 From 5d54a5c14cfec73f1336a5e06d255efbfe407237 Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Tue, 23 Dec 2025 11:58:25 -0300 Subject: [PATCH 3/3] refactor: avoid use of commons.lang3 Close #174 --- .../flowingcode/vaadin/addons/googlemaps/GoogleMap.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java b/src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java index a1d01ac..77e3687 100644 --- a/src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java +++ b/src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java @@ -47,7 +47,6 @@ import java.util.List; import java.util.concurrent.CompletableFuture; import lombok.experimental.ExtensionMethod; -import org.apache.commons.lang3.StringUtils; @SuppressWarnings("serial") @Tag("google-map") @@ -83,14 +82,18 @@ public enum MapType { */ public GoogleMap(String apiKey, String clientId, String language) { getElement().setAttribute("api-key", apiKey); - if (!StringUtils.isEmpty(clientId)) { + if (!isEmpty(clientId)) { getElement().setAttribute("client-id", clientId); } - if (!StringUtils.isEmpty(language)) { + if (!isEmpty(language)) { getElement().setAttribute("language", language); } } + private static boolean isEmpty(final String s) { + return s == null || s.length() == 0; + } + @Synchronize("google-map-idle") public Double getLatitude() { return getElement().getProperty("latitude", 0d);