Update swiftmailer to >= 5.4.4

[KatharinaSt]

Current version is 6.0.1 so it would be great to be able to use the newest version.

As Swiftmailer 5.4.4 has a security vulnerability at least a minor update would be reasonable.
http://www.cvedetails.com/cve/CVE-2016-10074/

[KatharinaSt]

This is the code I used to make sfMailer work with Swiftmailer 6.0.1:

Instantiation with $subject via "new":

public function compose($from = null, $to = null, $subject = null, $body = null)
{
    return (new Swift_Message($subject))
        ->setFrom($from)
        ->setTo($to)
        ->setBody($body)
    ;
}

and type hint in send():

public function send(Swift_Mime_SimpleMessage $message, &$failedRecipients = null)
{
    //...
}

[j0k3r]

Feel free to provide a PR to update the composer.json, the submodule and sfMailer (be careful about compatibility)

[rsantellan]

Migrate to swiftmailer 6 will break the php mail transport. That's ok?

[j0k3r]

I'm not ok.
Maybe we can provide a different sfMailer or a way to configure it to be used with switf 5 or 6.

I've checked swiftmailer 6.

[mentalstring]

Something to take into account is that Swiftmailer 6 has set PHP 7.0 as minimum.

[j0k3r]

Which means we won't upgrade the version within symfony1 to avoid losing PHP 5 compatibility

[mentalstring]

@j0k3r How about cloning sfMailer into a sfMailer6 of sorts with the needed changes to give the option of using swiftmailer 6 for those that are using PHP 7.0+? There would be a bit of code duplication, but on its own class it shouldn't interfere with the rest. Happy to try to put a PR together for this if you think this could be a viable option.

[alquerci]

@mentalstring look at #240

[thirsch]

@KatharinaSt #240 has been merged. You can now use swiftmailer 6 :)