Namespace leakage in Font.

[NicolBolas]

The Font.hpp file has many using directives in it. But these are at global scope, so anyone who does #include<Font.hpp> will automatically get all of thoseusing`s.

This is generally considered rather rude, since using directives cannot be undone. You should either explicitly qualify these things or put the using directives in the scope of the class/function where they are used.

[thecoshman]

Valid point, but Font.hpp is only on a 'dev test' branch, not master. As such, you are sort of commenting on something that does not exist.

[bananu7]

One of the points of dev branch is to catch those issues early. This is of course a valid concern.

[thecoshman]

Indeed, but last I checked, this was not something that was within the scope of gldr. It was brought in as part of you pulling in an existing codebase to make use of.