-
Notifications
You must be signed in to change notification settings - Fork 30
Description
I'm surprised to see the Page component. The semantic approach to producing a page would be Header -> Content -> Footer - so the concept of a Page element doesn't really fit my understanding of good semantics.
It would be bad practice to break the page over two components
Header Component =
Footer Component =
Header Component where the Title, subtitles and intro all modified based on route but the general header structure remains the same
where the page or views content sites
Footer Component = The end of the page - be it a footer or whatever closes your correctly
Header and Footer components could be extended - or app headers could include Atlantis headers.
I'm also surprised to see there are no navigation or sidebar elements despite that structure being used on getjobber.com (sidebar/header/navigation) and the report scheduler (header/navigation).
I think this is a really important area to address if you want developers to use Atlantis - as at the moment it just gets messy if I try to use the Page pattern you're suggesting.