From 0924e3d53d97962dc7e5e030e1f59a7683ef9c0c Mon Sep 17 00:00:00 2001 From: djs Date: Sat, 13 Dec 2025 17:09:53 +0100 Subject: [PATCH 1/2] Check that activity has application_id before attempting to compare --- CHANGELOG.md | 6 ++++++ oblivionis/bot.py | 5 ++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9639dc5..3640a74 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ ## [X.X.X] - 202X-XX-XX +## [0.3.1] - 2025-12-13 + +### Fixed + +- Check that activity has `application_id` before attempting to compare + ## [0.3.0] - 2025-09-21 ### Added diff --git a/oblivionis/bot.py b/oblivionis/bot.py index 59afa87..95bc913 100644 --- a/oblivionis/bot.py +++ b/oblivionis/bot.py @@ -26,7 +26,10 @@ def are_activities_equal(a, b) -> bool: case (_, None) | (None, _): return False case (x, y): - return x.name == y.name and x.application_id == y.application_id + same_name = x.name == y.name + if hasattr(x, "application_id") and hasattr(y, "application_id"): + return same_name and x.application_id == y.application_id + return same_name return False From 6d69454f8b9076a231878f1f41abf77e037717b1 Mon Sep 17 00:00:00 2001 From: djs Date: Sat, 13 Dec 2025 17:44:44 +0100 Subject: [PATCH 2/2] Equal if neither has application_id --- oblivionis/bot.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/oblivionis/bot.py b/oblivionis/bot.py index 95bc913..2fd7ee1 100644 --- a/oblivionis/bot.py +++ b/oblivionis/bot.py @@ -26,10 +26,9 @@ def are_activities_equal(a, b) -> bool: case (_, None) | (None, _): return False case (x, y): - same_name = x.name == y.name - if hasattr(x, "application_id") and hasattr(y, "application_id"): - return same_name and x.application_id == y.application_id - return same_name + x_app_id = getattr(x, "application_id", None) + y_app_id = getattr(y, "application_id", None) + return x.name == y.name and x_app_id == y_app_id return False