A lot temporary data in userData

[schriftgestalt]

It seems that the plugin is adding a lot stuff to the userData of layers (com.hugojourdan.ColorFlow_Color_XX) and font (e.g. com.hugojourdan.ColorFlow-currentFont) that is always recalculated and so it shouldn’t be stored in the .glyphs file. Please use the layer.tempData for this.

[Mark2Mark]

I think some of the functions should come with a very prominent warning and an option to cancel those operations before they happen.

I just removed a ton of that userData from a file, which was 2.7MB and then bloated up after the plugin use to 3.8MB. Might not sound much, but this is intense.
Had to use regex to get rid of everything without destroying my file. Took me quite a while. (In case someone needs it, it was (com\.hugojourdan\.ColorFlow)(.*\n)*?\};, but I am not sure if it’s perfect, at least it worked for me, but needs some manual cleanup as well. Don’t use this blindly (!)

If it is really necessary to write so much data for every glyph and every layer, maybe consider using a separate file that sits next to the glyphs file?

I uninstalled the plugin for now. When plugins fiddle too much with my file, it’s kinda scary. Luckily it’s under version control, but not everyone does that and sees all the added stuff.

Just my 2 cents.

[schriftgestalt]

Removing this with a script inside glyphs is reasonable easy:

import time
removeKeys = [
	"com.typemytype.robofont.layerData",
	"com.hugojourdan.ColorFlow_Color_1",
	"com.hugojourdan.ColorFlow_Color_10",
	"com.hugojourdan.ColorFlow_Color_11",
	"com.hugojourdan.ColorFlow_Color_2",
	"com.hugojourdan.ColorFlow_Color_3",
	"com.hugojourdan.ColorFlow_Color_4",
	"com.hugojourdan.ColorFlow_Color_5",
	"com.hugojourdan.ColorFlow_Color_6",
	"com.hugojourdan.ColorFlow_Color_8",
	"layerinfo.color"
]
start = time.time()
for g in Font.glyphs:
	for l in g.layers:
		if len(l.userData) > 0:
			for key in removeKeys:
				if key in l.userData:
					del(l.userData[key])
print("done: %.2f", (time.time() - start))

[Mark2Mark]

Saved for next time. Thanks a lot!
(There are more keys, though. E.g.
com.hugojourdan.ColorFlow-selectedMaster
com.hugojourdan.ColorFlow-selectedLayer
com.hugojourdan.ColorFlow-selectedLayer-data
com.hugojourdan.ColorFlow-Report_Data (that’s a biggie)
com.hugojourdan.ColorFlow)

Hence the regex helped me to even find all those)

[HugoJourdan]

It seems that the plugin is adding a lot stuff to the userData of layers (com.hugojourdan.ColorFlow_Color_XX) and font (e.g. com.hugojourdan.ColorFlow-currentFont) that is always recalculated and so it shouldn’t be stored in the .glyphs file. Please use the layer.tempData for this.

I'm not sure if layer.tempData is a solution, because some data need to be store in the file, and not only manipulate.
A possible solution could be to use layer.tempData, and when file is close/save, saved all theses data in font.layerData.
This data could be loaded and copy in layer.tempData when a glyph file is opened.
layer.userData are the only ways to be able to filter color flow data with a smart filter.

I think some of the functions should come with a very prominent warning and an option to cancel those operations before they happen.

I will update the README.md and maybe add an extra warning when user uses ColorFlow for the first time.

If it is really necessary to write so much data for every glyph and every layer, maybe consider using a separate file that sits next to the glyphs file?

I prefer not to use an additional file, this makes it easier to collaborate on the same file. Apart from making the source file heavier, I don't see much of a problem with keeping this data in the .glyph file.

Removing this with a script inside glyphs is reasonable easy:

Thanks @schriftgestalt, I will add an extra feature in the Action button to remove all datas related to ColorFlow.

[schriftgestalt]

I'm not sure if layer.tempData is a solution, because some data need to be store in the file, and not only manipulate.

Put everything that is really needed to be stored (meaning it can’t be re-computed) in userData, everything else in tempData.

And maybe use a bit shorter key. As long as it is clear where it comes from, it doesn’t need the full revers domain structure.