Handler of incoming OSC messages in sever.py causes errors

[pikseliahky]

The handler parses the message incorrectly. OSC messages are sent as flat sequence so there are no positional vs keyword arguments. In order for the OSC messaging (e.g. from SuperCollider) to work, this change solved the problem. I am not a Python coder, so not sure if this does not break something else though, but this works:

@osc.handle('/notochord/feed_query', return_port=send_port)
    def _(address, *args, **kw):
        if not kw and len(args) % 2 == 0:
            it = iter(args)
            kw = dict(zip(it, it))
            args = []

        print(f"{address} {args=} {kw=}")
        r = predictor.feed_query(*args, **kw)
        return (
            '/return/notochord/query',
            *[x for pair in r.items() for x in pair])

[victor-shepardson]

the osc.handle decorator from iipyper parses OSC messages in various ways. one of those ways is to interpret flat lists of OSC arguments as list of key-value pairs. That's what the Splat type annotation means.

It would be helpful if you would report the errors you're seeing.

[pikseliahky]

Without the above fix I was getting "TypeError: Notochord.feed_query() got multiple values for argument 'pitch'". I double checked that 'pitch' in the OSC message was sent only once though, so the error comes from parsing on the python side. When sending an OSC message with a flat list of arguments, the handler apparently could not parse positional and keyword arguments correctly and misleadingly interpreted some of the first arguments as pitch thus causing the error.

[victor-shepardson]

ahhh right, my mistake. Splat[4] actually means there are four positional arguments. it's not expecting to get keywords for the instrument, pitch, time, and velocity arguments to feed. It would be nice if it could handle both cases correctly... but I'm not sure if it's possible to disambiguate them in general.

you should send just four values for instrument, pitch, time, and velocity without any names. after that you can add keyword pairs for any arguments to query you want to include. something like this:

/notochord/feed_query 1 60 0.2 99 next_inst 1 pitch_temp 0.5

meaning, "feed an event on Grand Piano with Pitch 60, 200ms after previous event, and Note On Velocity 99; return a following event given that it's also on the Grand Piano and use a reduced temperature to sampling the pitch"

[pikseliahky]

Right, thank you! That should work - so the SuperCollider examples in the iil-examples repo should be updated accordingly.

[victor-shepardson]

egh yes you're right. I don't like that it becomes less clear from the SC side even though it better matches the Python API. I don't have time to reconsider this now so I'll just change the examples to work as you suggest.

Thanks, and let me know if you find other ways the SC examples have rotted!