Reading dynamic ErrorMessages from resource file

[smurugavel]

First, great work on getting this accomplished for angular-agility. Though everything works as expected for AA, I am trying to get localized error messages from resource file.

The error is noticed in loading resource file.
It fails to load the resource file on the GetObjectType method. I also noticed, assemblyNames array has one null item instead of resource file name.

Error: {"Value cannot be null.\r\nParameter name: assemblyString"}

is there a working sample for resource file?

public class TypeHelper { public static Type GetObjectType(string objectName, bool isNameFullyQualified, string alternateNamespace, params string[] assemblyNames) { Type type = null;

        AppDomain.CurrentDomain.ReflectionOnlyAssemblyResolve += CurrentDomain_ReflectionOnlyAssemblyResolve;
        AppDomain.CurrentDomain.ReflectionOnlyAssemblyResolve += CurrentDomain_ReflectionOnlyAssemblyResolve;

        foreach (var asmName in assemblyNames)
        {
            var assembly = Assembly.Load(asmName);
            type = GetTypeFromAssembly(assembly, objectName, isNameFullyQualified, alternateNamespace);
        }

        return type;
    }

[richinator38]

Did you look at ValidationHelperTests? Also, please post your call to ValidationHelper.GetValidations. Thanks!

[smurugavel]

I did look at it and I see that resource file was used in test project.

So, I downloaded a github copy of sourcecode yesterday and tested it by adding a resource file to AATestAPI project. Result is same and I did not see error message being read from resource file. I am not sure what I am missing.
This is what I did to test github copy:

1. Add resource file Resource1.resx to AATestAPI
2. Add attributes to AATestAPI.Models.ValidationTest.model.Name as below

[Required(ErrorMessageResourceName="RequiredField",ErrorMessageResourceType=typeof(Resource1))] public string Name { get; set; }

And, here is my call to ValidationHelper.GetValidations that you asked for.

object jsonObject = helper.GetValidations("Person", "personVM", "myProj.Models", false, "myProj.Models");


Thanks !!

[richinator38]

You need to call the GetValidations with the GetValidationsParms parameter. It has these two fields in it:

public string ResourceNamespace { get; set; }

public string ResourceAssemblyName { get; set; }

If you don't have that class, you may need to get the latest version.

[richinator38]

I updated the docs.

[smurugavel]

Thanks for updating the docs. I guess that helped to get strings from resource file

Actually, I used nuget binaries, thanks for pointing me to get the latest version.
At this time, I am not sure if nuget needs an update?

[smurugavel]

In case someone is looking for resource file options..

I had to code this way to get the resource strings.

parms.ResourceNamespace = "Assembly.Models.resourcefilename.resx"


My resource file's build action property value = "Embedded Resource"

[pkelbern]

I would include the following code
if(msg == null) { the resource default value try { if(attr.AttributeType.Name.EndsWith("Attribute")) { var rtype = TypeHelper.GetObjectType(resourceNamespace, true, resourceNamespace, resourceAssemblyName); if (rtype != null) { var resName = rtype.GetProperty(attr.AttributeType.Name.Substring(0, attr.AttributeType.Name.Length - 9 /*Attribute*/), BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static); if (resName != null) { msg = resName.GetValue(null) as string; } } } } catch { msg = null; } }

To be included in the GetErrorMessage method in BaseValidationConverter Class, so it would set a default resource error message text .

[wurmr]

@pkelbern could you submit a pull request with the changes you propose? Easier to evaluate and merge in.

[pkelbern]

I couldn't submit a pull request, so I made a fork.

[wurmr]

@pkelbern Great! Forking is the first step. Make the changes you want in your fork and test them out. Once you are happy with them submit a pull request from your fork into this repository.