From a0111fa8b19525c6e9f0a9ddb8a15b334c1edfdf Mon Sep 17 00:00:00 2001 From: Leonidas Vrachnis Date: Tue, 14 Aug 2018 21:04:49 +0300 Subject: [PATCH 1/2] doRequest must accept null $collectorRegistry Since method delete calls it with null --- src/Prometheus/PushGateway.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Prometheus/PushGateway.php b/src/Prometheus/PushGateway.php index a4a3fd2..74f3bbc 100644 --- a/src/Prometheus/PushGateway.php +++ b/src/Prometheus/PushGateway.php @@ -60,7 +60,7 @@ public function delete($job, $groupingKey = null) * @param $groupingKey * @param $method */ - private function doRequest(CollectorRegistry $collectorRegistry, $job, $groupingKey, $method) + private function doRequest(?CollectorRegistry $collectorRegistry, $job, $groupingKey, $method) { $url = "http://" . $this->address . "/metrics/job/" . $job; if (!empty($groupingKey)) { From 42ca3eae7ae5c27675ead133e317099e843885e8 Mon Sep 17 00:00:00 2001 From: Leonidas Vrachnis Date: Tue, 14 Aug 2018 21:40:04 +0300 Subject: [PATCH 2/2] Fix php 5.6 incompatibility --- src/Prometheus/PushGateway.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Prometheus/PushGateway.php b/src/Prometheus/PushGateway.php index 74f3bbc..91c94f6 100644 --- a/src/Prometheus/PushGateway.php +++ b/src/Prometheus/PushGateway.php @@ -60,7 +60,7 @@ public function delete($job, $groupingKey = null) * @param $groupingKey * @param $method */ - private function doRequest(?CollectorRegistry $collectorRegistry, $job, $groupingKey, $method) + private function doRequest(CollectorRegistry $collectorRegistry = null, $job, $groupingKey, $method) { $url = "http://" . $this->address . "/metrics/job/" . $job; if (!empty($groupingKey)) {