From 1bd66d9b4a168747e3fd89aeb86c79dd0b0e69fb Mon Sep 17 00:00:00 2001 From: 4f77616973 <0x4f@tuta.io> Date: Wed, 8 Feb 2023 11:09:23 +0530 Subject: [PATCH 1/2] added 5 digit card pin support --- app/src/main/kotlin/cloud/keyspace/android/AddCard.kt | 2 +- app/src/main/res/layout/edit_card.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/kotlin/cloud/keyspace/android/AddCard.kt b/app/src/main/kotlin/cloud/keyspace/android/AddCard.kt index ae76dd5..b5f2db8 100644 --- a/app/src/main/kotlin/cloud/keyspace/android/AddCard.kt +++ b/app/src/main/kotlin/cloud/keyspace/android/AddCard.kt @@ -388,7 +388,7 @@ class AddCard : AppCompatActivity() { if (cardNumberInput.text.toString().replace(" ", "").length < 16) cardNumberInput.error = "Enter a valid 16 digit card number" else if (cardNumberInput.text.toString().replace(" ", "").length in 17..18 || cardNumberInput.text.toString().replace(" ", "").length > 19) cardNumberInput.error = "Enter a valid 19 digit card number" - else if (securityCode.text.toString().length !in 3..4) securityCode.error = "Enter a valid security code" + else if (securityCode.text.toString().length !in 3..5) securityCode.error = "Enter a valid security code" else if (toDate.text.toString().isEmpty()) toDate.error = "Enter an expiry date" else if (cardholderNameInput.text.toString().isEmpty()) cardholderNameInput.error = "Enter card holder's name" else if (nameInput.text.toString().isEmpty()) nameInput.error = "Enter a name. This can be your bank's name." diff --git a/app/src/main/res/layout/edit_card.xml b/app/src/main/res/layout/edit_card.xml index c0d99ad..4a4ebe0 100644 --- a/app/src/main/res/layout/edit_card.xml +++ b/app/src/main/res/layout/edit_card.xml @@ -278,7 +278,7 @@ android:fontFamily="monospace" android:inputType="none|phone" android:letterSpacing="0.05" - android:maxLength="4" /> + android:maxLength="5" /> From 6e155cf7db0bcdea07418a514a5c516cd5ffa995 Mon Sep 17 00:00:00 2001 From: 4f77616973 <0x4f@tuta.io> Date: Wed, 8 Feb 2023 11:32:12 +0530 Subject: [PATCH 2/2] added 5 and 6 digit PIN support --- app/src/main/kotlin/cloud/keyspace/android/AddCard.kt | 6 +++--- app/src/main/res/layout/edit_card.xml | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/main/kotlin/cloud/keyspace/android/AddCard.kt b/app/src/main/kotlin/cloud/keyspace/android/AddCard.kt index b5f2db8..4d58933 100644 --- a/app/src/main/kotlin/cloud/keyspace/android/AddCard.kt +++ b/app/src/main/kotlin/cloud/keyspace/android/AddCard.kt @@ -388,11 +388,11 @@ class AddCard : AppCompatActivity() { if (cardNumberInput.text.toString().replace(" ", "").length < 16) cardNumberInput.error = "Enter a valid 16 digit card number" else if (cardNumberInput.text.toString().replace(" ", "").length in 17..18 || cardNumberInput.text.toString().replace(" ", "").length > 19) cardNumberInput.error = "Enter a valid 19 digit card number" - else if (securityCode.text.toString().length !in 3..5) securityCode.error = "Enter a valid security code" + else if (securityCode.text.toString().length !in 3..4) securityCode.error = "Enter a valid security code" else if (toDate.text.toString().isEmpty()) toDate.error = "Enter an expiry date" else if (cardholderNameInput.text.toString().isEmpty()) cardholderNameInput.error = "Enter card holder's name" else if (nameInput.text.toString().isEmpty()) nameInput.error = "Enter a name. This can be your bank's name." - else if (isAtmCard.isChecked && atmPinInput.text.toString().length < 4) atmPinInput.error = "Enter a valid Personal Identification Number" + else if (isAtmCard.isChecked && atmPinInput.text.toString().length !in 4..6) atmPinInput.error = "Enter a valid Personal Identification Number" else { @@ -411,7 +411,7 @@ class AddCard : AppCompatActivity() { cardholderName = cardholderNameInput.text.toString(), expiry = toDate.text.toString(), notes = notesInput.text.toString(), - pin = if (atmPinInput.text.toString().length == 4 && isAtmCard.isChecked) atmPinInput.text.toString() else "", + pin = if (atmPinInput.text.toString().length == 4 && isAtmCard.isChecked) atmPinInput.text.toString() else null, securityCode = securityCode.text.toString(), customFields = customFieldsData, rfid = hasRfidChip.isChecked, diff --git a/app/src/main/res/layout/edit_card.xml b/app/src/main/res/layout/edit_card.xml index 4a4ebe0..6094ebc 100644 --- a/app/src/main/res/layout/edit_card.xml +++ b/app/src/main/res/layout/edit_card.xml @@ -278,7 +278,7 @@ android:fontFamily="monospace" android:inputType="none|phone" android:letterSpacing="0.05" - android:maxLength="5" /> + android:maxLength="4" /> @@ -346,7 +346,7 @@ android:digits="0123456789" android:fontFamily="monospace" android:inputType="none|phone" - android:maxLength="4" /> + android:maxLength="6" />