From 4195e9dd4bd1169fcfa2ef9fe7e42c29e9f901d1 Mon Sep 17 00:00:00 2001 From: hpnightowl Date: Tue, 28 Feb 2023 13:07:33 +0530 Subject: [PATCH 1/6] keyspace: drop hardcoded strings - can be helpful later in traslations as well --- app/src/main/res/layout/login.xml | 10 +++++----- app/src/main/res/values/strings.xml | 5 +++++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/app/src/main/res/layout/login.xml b/app/src/main/res/layout/login.xml index 96ee6ff..8d3f7de 100644 --- a/app/src/main/res/layout/login.xml +++ b/app/src/main/res/layout/login.xml @@ -62,7 +62,7 @@ android:drawingCacheQuality="low" android:gravity="center|start" android:paddingHorizontal="8dp" - android:text="123 456" + android:text="@string/_123_456" android:textSize="32sp" android:textStyle="normal" /> @@ -81,7 +81,7 @@ android:scrollbars="none" android:scrollHorizontally="true" android:singleLine="true" - android:text="Site Name" + android:text="@string/site_name" android:textSize="22sp" /> + 123 456 + Site Name + Username / Email + Tag + Misc \ No newline at end of file From 5fbf512bdd0b7974088f328be2c8546807cc0f48 Mon Sep 17 00:00:00 2001 From: hpnightowl Date: Tue, 28 Feb 2023 13:09:18 +0530 Subject: [PATCH 2/6] keyspace: change textsize to sp from dp - it should follow userpreference font size --- app/src/main/res/layout/login.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/res/layout/login.xml b/app/src/main/res/layout/login.xml index 8d3f7de..24221b0 100644 --- a/app/src/main/res/layout/login.xml +++ b/app/src/main/res/layout/login.xml @@ -103,7 +103,7 @@ android:singleLine="true" android:text="@string/username_email" - android:textSize="16dp" + android:textSize="16sp" android:visibility="visible" app:drawableStartCompat="@drawable/ic_baseline_account_circle_24" /> From 42459d28d34bd6afd57679344b644dc3d2148f09 Mon Sep 17 00:00:00 2001 From: hpnightowl Date: Tue, 28 Feb 2023 13:36:34 +0530 Subject: [PATCH 3/6] keyspace: respect RTL layout as well --- app/src/main/res/layout/login.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/src/main/res/layout/login.xml b/app/src/main/res/layout/login.xml index 24221b0..a877104 100644 --- a/app/src/main/res/layout/login.xml +++ b/app/src/main/res/layout/login.xml @@ -140,6 +140,7 @@ android:marqueeRepeatLimit="marquee_forever" android:paddingVertical="10dp" android:paddingEnd="5dp" + android:paddingStart="5dp" android:scrollbars="none" android:scrollHorizontally="true" android:singleLine="true" @@ -161,6 +162,7 @@ android:marqueeRepeatLimit="marquee_forever" android:padding="10dp" android:paddingEnd="5dp" + android:paddingStart="5dp" android:scrollbars="none" android:scrollHorizontally="true" android:singleLine="true" From a22908b32eeffe685c2fe4fbcd749834e5b56868 Mon Sep 17 00:00:00 2001 From: hpnightowl Date: Tue, 28 Feb 2023 14:22:32 +0530 Subject: [PATCH 4/6] keyspace: logins: make it searchable layout - reason behind it is simple like a normal person we will see first what site the 2fa is needed for then we go the email for which it is needed then we go with the 2fa. from top hierarchy prespective. --- app/src/main/res/layout/login.xml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/app/src/main/res/layout/login.xml b/app/src/main/res/layout/login.xml index a877104..b66cc22 100644 --- a/app/src/main/res/layout/login.xml +++ b/app/src/main/res/layout/login.xml @@ -53,19 +53,6 @@ android:orientation="vertical" android:paddingVertical="7.5dp"> - - + + From c30de716881d83911066b65341da2fbcbd48ab02 Mon Sep 17 00:00:00 2001 From: hpnightowl Date: Tue, 28 Feb 2023 14:03:54 +0530 Subject: [PATCH 5/6] keyspace: login: add constraint progressbar below login card --- app/src/main/res/layout/login.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/res/layout/login.xml b/app/src/main/res/layout/login.xml index b66cc22..7bbc0c0 100644 --- a/app/src/main/res/layout/login.xml +++ b/app/src/main/res/layout/login.xml @@ -125,6 +125,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toBottomOf="@+id/LoginInformation" app:trackColor="@android:color/transparent" app:trackThickness="4dp" /> @@ -161,8 +162,8 @@ android:gravity="center|end" android:marqueeRepeatLimit="marquee_forever" android:padding="10dp" - android:paddingEnd="5dp" android:paddingStart="5dp" + android:paddingEnd="5dp" android:scrollbars="none" android:scrollHorizontally="true" android:singleLine="true" From 91373af7a1d0c7231aeccbf1cdcbd09217c4d443 Mon Sep 17 00:00:00 2001 From: hpnightowl Date: Tue, 28 Feb 2023 14:35:17 +0530 Subject: [PATCH 6/6] keyspace: tag/misc: improve margins --- app/src/main/res/layout/login.xml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/res/layout/login.xml b/app/src/main/res/layout/login.xml index 7bbc0c0..62166d3 100644 --- a/app/src/main/res/layout/login.xml +++ b/app/src/main/res/layout/login.xml @@ -133,7 +133,8 @@ android:id="@+id/TagText" android:layout_width="wrap_content" android:layout_height="0dp" - android:layout_marginHorizontal="5dp" + android:layout_marginVertical="10dp" + android:layout_marginHorizontal="10dp" android:drawablePadding="5dp" android:ellipsize="marquee" android:fadingEdge="horizontal" @@ -155,7 +156,8 @@ android:id="@+id/MiscText" android:layout_width="wrap_content" android:layout_height="0dp" - android:layout_marginHorizontal="5dp" + android:layout_marginHorizontal="10dp" + android:layout_marginVertical="10dp" android:drawablePadding="5dp" android:ellipsize="marquee" android:fadingEdge="horizontal"