From de30fedeca865b6d7b53c0fdaacaffe2e645a4fc Mon Sep 17 00:00:00 2001 From: William Allen <16820599+williamjallen@users.noreply.github.com> Date: Thu, 8 Jan 2026 10:12:44 -0500 Subject: [PATCH 1/2] Fix build overview undefined project service error (#3359) --- resources/views/build/overview.blade.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/resources/views/build/overview.blade.php b/resources/views/build/overview.blade.php index 48aab1da33..4bb5ead7f2 100644 --- a/resources/views/build/overview.blade.php +++ b/resources/views/build/overview.blade.php @@ -1,3 +1,5 @@ +@use(App\Services\ProjectService) + @extends('cdash', [ 'title' => 'Build Overview' ]) From 64196230eb8efb659bcaddeda61dcd433ec222e6 Mon Sep 17 00:00:00 2001 From: William Allen <16820599+williamjallen@users.noreply.github.com> Date: Thu, 8 Jan 2026 11:19:12 -0500 Subject: [PATCH 2/2] Fix bad error checking in build error handling logic (#3358) The legacy BuildError and BuildFailure models are treated as if they're derived from the same parent class in the build handler, but there's no guarantee that the fields the build handler attempts to access actually exist on a particular object. This PR resolves a critical issue introduced by https://github.com/Kitware/CDash/pull/3320 which causes failures when parsing builds with old style build errors. --- app/Http/Submission/Handlers/BuildHandler.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/Http/Submission/Handlers/BuildHandler.php b/app/Http/Submission/Handlers/BuildHandler.php index 66460d1fe8..4eaef051d1 100644 --- a/app/Http/Submission/Handlers/BuildHandler.php +++ b/app/Http/Submission/Handlers/BuildHandler.php @@ -451,10 +451,7 @@ public function endElement($parser, $name): void if ($threshold > 0) { $chunk_size = $threshold / 2; foreach (['StdOutput', 'StdError'] as $field) { - if (!($this->Error instanceof BuildFailure)) { - throw new RuntimeException('Field "Error" is not instance of BuildFailure.'); - } - if (isset($this->Error->$field)) { + if ($this->Error instanceof BuildFailure && isset($this->Error->$field)) { $outlen = strlen($this->Error->$field); if ($outlen > $threshold) { // First try removing suppressed warnings to see