--check-recommended-extensions not working

[hippysurfer]

I have trying running sync with PR "Failing to download extensions #81".

When I run the following:

python3 ./sync.py --artifacts ./artifacts --check-recommended-extensions

I see:

[I 250815 09:25:37 sync:794] Syncing VS Code Recommended Extensions
[I 250815 09:25:37 sync:478] Searching for top 500 recommended extensions
Traceback (most recent call last):
File "/home/rjt/tmp/vscodeoffline/vscoffline/./sync.py", line 795, in
recommended = mp.get_recommendations(os.path.abspath(
config.artifactdir), config.totalrecommended)
File "/home/rjt/tmp/vscodeoffline/vscoffline/./sync.py", line 375, in get_recommendations
recommended_old = self.get_recommendations_old(destination)
File "/home/rjt/tmp/vscodeoffline/vscoffline/./sync.py", line 416, in get_recommendations_old
for recommendation in jresult['workspaceRecommendations']:

Doing a bit of digging, it appears that the "workspaceRecommendations" key is not present in the json file that is downloaded from:

https://main.vscode-cdn.net/extensions/marketplace.json

I have search around I can not find anything online about this. I have tried to search the VScode code to find where it is downloading its "recommendations" from, but to no avail so far.

(PS. Thank you for this very useful tool).

[LOLINTERNETZ]

Thanks for looking into this. It's related to #81 and it looks like the workspace recommendations works differently now.

How does it work? I also have no idea yet. There must be a fetch I haven't found yet (possibly by the Electron binary rather than the webapp) which grabs the ~10 recommended item names, and then then the usual extension queries are used.

This is worked around for now by just fetching the top 200-500 extensions, but I'll need to look into it more to see if there's a 'more correct' way.