diff --git a/LDK/api-src/org/labkey/api/ldk/table/AbstractDataDefinedTable.java b/LDK/api-src/org/labkey/api/ldk/table/AbstractDataDefinedTable.java index fe0cb3a8..a974a4d7 100644 --- a/LDK/api-src/org/labkey/api/ldk/table/AbstractDataDefinedTable.java +++ b/LDK/api-src/org/labkey/api/ldk/table/AbstractDataDefinedTable.java @@ -57,7 +57,7 @@ * Date: 4/2/13 * Time: 2:54 PM */ -abstract public class AbstractDataDefinedTable extends CustomPermissionsTable +abstract public class AbstractDataDefinedTable extends CustomPermissionsTable { protected String _pk; @@ -65,7 +65,7 @@ abstract public class AbstractDataDefinedTable extends CustomPermissionsTable protected String _filterValue; protected String _valueColumn; - public AbstractDataDefinedTable(UserSchema schema, SchemaTableInfo table, ContainerFilter cf, String filterColumn, String valueColumn, String tableName, String filterValue) + public AbstractDataDefinedTable(SchemaType schema, SchemaTableInfo table, ContainerFilter cf, String filterColumn, String valueColumn, String tableName, String filterValue) { super(schema, table, cf); _filterColumn = filterColumn; @@ -77,7 +77,7 @@ public AbstractDataDefinedTable(UserSchema schema, SchemaTableInfo table, Contai } @Override - public CustomPermissionsTable init() + public CustomPermissionsTable init() { super.init(); @@ -85,7 +85,7 @@ public CustomPermissionsTable init() addCondition(col, _filterValue); //enforce only showing rows from this category List pks = getRealTable().getPkColumnNames(); - assert pks.size() > 0; + assert !pks.isEmpty(); _pk = pks.get(0); var valueCol = getMutableColumn(_valueColumn); @@ -93,7 +93,7 @@ public CustomPermissionsTable init() valueCol.setKeyField(true); valueCol.setNullable(false); - getMutableColumn(_pk).setKeyField(false); + getMutableColumnOrThrow(_pk).setKeyField(false); ColumnInfo filterCol = getColumn(_filterColumn); assert filterCol != null; @@ -135,7 +135,7 @@ protected class UpdateService extends SimpleQueryUpdateService { private final ValuesManager _vm; - public UpdateService(SimpleUserSchema.SimpleTable ti) + public UpdateService(SimpleUserSchema.SimpleTable ti) { super(ti, ti.getRealTable()); @@ -217,8 +217,7 @@ public boolean testIfRowExists(String value) { boolean ret = _distinctValues.contains(value); - if (!_distinctValues.contains(value)) - _distinctValues.add(value); + _distinctValues.add(value); return ret; }