Sigmoid Function is Incorrect

[oalieno]

asm2vec/asm2vec/internal/training.py

Lines 187 to 188 in 6e975f0

	def _sigmoid(x: float) -> float:
	return 1 / (1 + np.exp(x))

should be

def _sigmoid(x: float) -> float:
    return 1 / (1 + np.exp(-x))

[oalieno]

After my calculation, if we use 1 / (1 + np.exp(x)) as sigmoid function, then the derivative in the code is correct.

asm2vec/asm2vec/internal/training.py

Line 234 in 6e975f0

g = (_identity(tk is sp_tk) - _dot_sigmoid(delta, tk.v_pred)) * context.alpha()

But if we want to use the regular sigmoid function 1 / (1 + np.exp(-x)). Then we need to change the derivative to the following, which only differ by a minus sign comparing with original derivative.

 g = (_dot_sigmoid(delta, tk.v_pred) - _identity(tk is sp_tk)) * context.alpha() 

Both are correct and produce the same result. But I think using the regular sigmoid function is less confusing.