APK at v3.0.0 was built from non-existing commit

[IzzySoft]

According to the embedded vcsInfo, the APK was built from commit ee959ac – which is not present here:

So we cannot build from it, and hence not confirm whether it is RB or not. As that change is available at the tagged commit, I assume it was squashed – or rather merged from a local branch after you built the APK? That is almost certain to break RB, as shown.

But even if I try to build simply from the tagged commit, the build fails:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':common:design:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
   > Android resource linking failed
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values/values.xml:2402: AAPT: error: style attribute 'attr/windowSplashScreenAnimatedIcon (aka com.androidvip.sysctlgui.design:attr/windowSplashScreenAnimatedIcon)' not found.
         
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values/values.xml:2403: AAPT: error: style attribute 'attr/windowSplashScreenAnimationDuration (aka com.androidvip.sysctlgui.design:attr/windowSplashScreenAnimationDuration)' not found.
         
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values/values.xml:2404: AAPT: error: style attribute 'attr/postSplashScreenTheme (aka com.androidvip.sysctlgui.design:attr/postSplashScreenTheme)' not found.
         
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values-night-v8/values-night-v8.xml:46: AAPT: error: style attribute 'attr/windowSplashScreenAnimatedIcon (aka com.androidvip.sysctlgui.design:attr/windowSplashScreenAnimatedIcon)' not found.
         
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values-night-v8/values-night-v8.xml:47: AAPT: error: style attribute 'attr/windowSplashScreenAnimationDuration (aka com.androidvip.sysctlgui.design:attr/windowSplashScreenAnimationDuration)' not found.
         
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values-night-v8/values-night-v8.xml:48: AAPT: error: style attribute 'attr/postSplashScreenTheme (aka com.androidvip.sysctlgui.design:attr/postSplashScreenTheme)' not found.

As that's just a verify, I ran ./gradlew assembleRelease -x :common:design:verifyReleaseResources to see if the build succeeds at least. It builds then, but is not reproducible: the diff between the two APKs is rather huge. For starters:

     XML ELEM START [lineno=2, name='manifest', #attributes=7]
-      ATTR: http://schemas.android.com/apk/res/android:versionCode=19
+      ATTR: http://schemas.android.com/apk/res/android:versionCode=17
       ATTR: http://schemas.android.com/apk/res/android:versionName='3.0.0'

So your APK shows versionCode: 19, while at the tag it is 17. Guess we'll have to declare this one failed then – unless you have an idea how to cure it?

[Lennoard]

I had to do a lot of f-ckery with the repo in order to rebase some of the changes even worse for play store approval. I do not have a straight solution for building off of the latest tag right now.

It will be best for me to create another tag/release with the current state of the repo (+ some fixes I have) and for you to skip this one. Unless you can build the APK directly from the main branch.

[IzzySoft]

Thanks for your swift response! I'd say the approach with a new release (having versionCode increased and `versionName as well) sounds the best. The current one will then just have no green shield (as RB failed), which hopefully is fixed with the next release then.

For planning on whether to check in the current failed results: any ETA for that new release? If within a day, I'd just "ignore" the failed one and wait for the next to succeed. If more, I'd check in the failed results (to prevent builds here from running in circles), and the shield would rather show an "not yet ready" white shield for the current release.

Unless you can build the APK directly from the main branch.

Building is only half of it. We always distribute the APK you've built and signed. Our builds are rather "checks" to see if the APK really matches the source it claims to have been built from. So building from main would not produce an identical APK, obviously, which means we'll have to wait for the next release.

And yeah, Play can be a pain in the … behind. We hope we're doing better there…

[Lennoard]

ETA is within 8 hours from now.
I'm planning to go for code 20 and name 3.0.1, this should be fine, right?

[IzzySoft]

ETA is within 8 hours from now.

Wow, that's fast. OK, then I'll pretend I did see nothing of the failed one 🙈

I'm planning to go for code 20 and name 3.0.1, this should be fine, right?

Totally fine, yes – thanks a lot!

[IzzySoft]

fatal: Could not parse object '6bde007043c32102b39470e1dd218c9f86fb9914'.

3.0.1 repeats the issue it seems.

[Lennoard]

I'm confused. Shouldn't it be commit a4eea53?

[IzzySoft]

That is what it should be, yes – unfortunately not what it is. Steps to follow:

• open the APK with a ZIP manager (or simply unzip it)
• navigate to META-INF/version-control-info.textproto
• look inside that file:

repositories {
  system: GIT
  local_root_path: "$PROJECT_DIR"
  revision: "6bde007043c32102b39470e1dd218c9f86fb9914"
}

The hash of the commit this APK was built from is marked in the revision line. And yes, that should match the tagged commit – but unfortunately, it does not. I have no idea where that commit comes from, as I don't know how/where you build. My guess is you use some local branch, and merge/push that only after the build (wrong order then).

Note that this issue only started with v3.0.0 – prior releases had the matching hash included.

[Lennoard]

Alright, thanks for the steps. I'll redo everything with that in mind to try and see if anything changes.

[Lennoard]

repositories {
  system: GIT
  local_root_path: "$PROJECT_DIR"
  revision: "ae417a5e22316cc53790628d3f55f82d5fdab326"
}

Latest v3.0.2 version-control-info.textproto that matches release commit:

[IzzySoft]

That seems to match now, confirmed. Build fails nevertheless:

FAILURE: Build failed with an exception.132 actionable tasks: 132 executed
Configuration cache entry stored.


* What went wrong:
Execution failed for task ':common:design:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
   > Android resource linking failed
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values/values.xml:2402: AAPT: error: style attribute 'attr/windowSplashScreenAnimatedIcon (aka com.androidvip.sysctlgui.design:attr/windowSplashScreenAnimatedIcon)' not found.
         
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values/values.xml:2403: AAPT: error: style attribute 'attr/windowSplashScreenAnimationDuration (aka com.androidvip.sysctlgui.design:attr/windowSplashScreenAnimationDuration)' not found.
         
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values/values.xml:2404: AAPT: error: style attribute 'attr/postSplashScreenTheme (aka com.androidvip.sysctlgui.design:attr/postSplashScreenTheme)' not found.
         
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values-night-v8/values-night-v8.xml:46: AAPT: error: style attribute 'attr/windowSplashScreenAnimatedIcon (aka com.androidvip.sysctlgui.design:attr/windowSplashScreenAnimatedIcon)' not found.
         
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values-night-v8/values-night-v8.xml:47: AAPT: error: style attribute 'attr/windowSplashScreenAnimationDuration (aka com.androidvip.sysctlgui.design:attr/windowSplashScreenAnimationDuration)' not found.
         
     ERROR: /build/repo/common/design/build/intermediates/merged_res/release/mergeReleaseResources/values-night-v8/values-night-v8.xml:48: AAPT: error: style attribute 'attr/postSplashScreenTheme (aka com.androidvip.sysctlgui.design:attr/postSplashScreenTheme)' not found.

As before, I can try disabling that gradle task – but I'm afraid the result won't be RB then anyway. Did you maybe forget to check in some files?