Enhance inetOrgPerson DTO with optional fields and validation improvements

Author: tacxou

src/management/identities/_dto/_parts/inetOrgPerson.dto.ts

@@ -1,5 +1,6 @@
 import { ApiProperty, PartialType } from '@nestjs/swagger';
-import {IsString, IsEmail, IsOptional, IsArray} from 'class-validator';
+import { Type } from 'class-transformer';
+import { IsString, IsEmail, IsOptional, IsArray } from 'class-validator';
 
 export class inetOrgPersonCreateDto {
   @IsString()
@@ -8,9 +9,11 @@ export class inetOrgPersonCreateDto {
 
   @IsString()
   @ApiProperty()
+  @IsOptional()
   public cn: string;
 
   @IsArray()
+  @Type(() => String)
   @IsString({ each: true })
   @ApiProperty()
   @IsOptional()
@@ -23,6 +26,7 @@ export class inetOrgPersonCreateDto {
   @ApiProperty()
   @IsArray()
   @IsString({ each: true })
+  @IsOptional()
   public departmentNumber: string[];
 
   @IsString()
@@ -52,6 +56,7 @@ export class inetOrgPersonCreateDto {
 
   @IsEmail()
   @ApiProperty({ required: false })
+  @IsOptional()
   public mail?: string;
 
   @IsOptional()

src/management/identities/_dto/identities.dto.ts

@@ -1,5 +1,5 @@
 import { ApiProperty, IntersectionType, PartialType } from '@nestjs/swagger';
-import { IsOptional, IsObject, IsEnum, IsNumber } from 'class-validator';
+import { IsOptional, IsObject, IsEnum, IsNumber, ValidateNested } from 'class-validator';
 import { inetOrgPersonDto } from './_parts/inetOrgPerson.dto';
 import { IdentityState } from '../_enums/states.enum';
 import { IdentityLifecycle } from '../_enums/lifecycle.enum';
@@ -35,6 +35,7 @@ export class IdentitiesCreateDto extends IntersectionType(CustomFieldsDto, Metad
   public lifecycle: number;
 
   @IsObject()
+  @ValidateNested()
   @Type(() => inetOrgPersonDto)
   @ApiProperty({ type: inetOrgPersonDto })
   public inetOrgPerson: inetOrgPersonDto;