SBP M1 review

[sbp-parity]

Hi ! I've been following the doc & guides, this is really super cool 😉

Here is few issues / comments:

• After a fresh project creation, (with subsembly init), yarn build does not work (though there is a build command in package.json), getting an error related to './cli/package.json' not being found. subsembly compile works as expected.
• In the sample guide, when creating a new Nicks module, the set_name function does not return correct values as per the u8[] return type (what's the story for custom error codes ?). Additionally, you could specify the ts imports :)
• When using the latest (production) Polkadot.js apps (v0.91.3-3), I encountered some decoding issues (displayed in the browser console) when displaying the account balances.
• In the documentation, for the primitives & pre-built (FRAME) modules, I think you could link back to the rust docs of the origin Substrate implementation e.g. for the Aura module -> https://substrate.dev/rustdocs/v2.0.1/pallet_aura/index.html. Also, you might want to specify which version of Substrate the current Subsembly implementation is API compatible with.
• Nitpick: in the GitBook docs, hyperlinks are not highlighted, only on mouse hover. I think it would be nice to see them directly, especially if you link back to the origin implementation's docs.
• Testing: what are your plans regarding the Testing story for subsembly ? In the original Substrate implementation, developers can create a mock of the runtime and write unit tests for their modules / pallets (and are strongly encouraged to do so, knowing the complexity / learning curve of Rust + Substrate). This seems to be a crucial topic to address early on (especially if a more substantial part of FRAME is being re-implemented in Subsembly), maybe for M2 or M3.
• I think it would be great to see a list or a matrix of the FRAME pallets that have been re-implemented so far (or are being worked on) in the Subsembly project. It would show how much work still remains, what are the areas where help is needed, and that would be a great way to engage more community members to contribute to the project.