format checking a little bit better and starting to parse more of the file. i have version started but it is dumb.

Author: LinuxDevon

src/dbc.hpp

@@ -1,4 +1,5 @@
 #include "exceptions/error.hpp"
+#include "util/utils.hpp"
 
 namespace libdbc {
 
@@ -7,16 +8,48 @@ namespace libdbc {
 		virtual ~Parser() = default;
 
 		virtual void parse_file(const std::string& file) = 0;
+
+	protected:
+
+		void verify_dbc_format(std::istream& file_stream) const {
+			std::string line;
+
+			Utils::SafeString::get_line(file_stream, line);
+
+			if(line.find("VERSION") == std::string::npos) {
+				throw validity_error();
+			}
+		}
 	};
 
 	class DbcParser : public Parser {
 	public:
 		virtual ~DbcParser() = default;
 
 		virtual void parse_file(const std::string& file) final override {
-			throw validity_error();
+			std::ifstream s(file.c_str());
+			std::string line;
+
+			verify_dbc_format(s);
+
+			while(!s.eof()) {
+				Utils::SafeString::get_line(s, line);
+
+			}
+
+		}
+
+		std::string get_version() const {
+			return "";
 		}
 
+	private:
+
+
+	};
+
+	struct Message {
+
 	};
 
 }

test/test_dbc.cpp

@@ -2,9 +2,19 @@
 #include "defines.hpp"
 #include "dbc.hpp"
 
-TEST_CASE("Load a simple 1 line message dbc", "[fileio]") {
+TEST_CASE("Testing dbc file loading", "[fileio]") {
 	auto parser = std::unique_ptr<libdbc::DbcParser>(new libdbc::DbcParser());
 
-	REQUIRE_THROWS_AS(parser->parse_file(DBC_FILE_2), libdbc::validity_error);
+	SECTION("Loading a non dbc file should throw an error", "[error]") {
+		REQUIRE_THROWS_AS(parser->parse_file(TEXT_FILE), libdbc::validity_error);
+	}
+
+	SECTION("Loading a single simple dbc file", "[dbc]") {
+		std::vector<libdbc::Message> messages;
+
+		parser->parse_file(DBC_FILE_2);
+
+		REQUIRE(parser->get_version() == "");
+	}
 
 }