atlases do not unzip in git master

[jcupitt]

Hello make install fails for atlases with git master. My guess is it's because it's now downloading a zip, but cmake is expecting a .tar.gz.

First, make succeeds with this output:

...
[ 48%] Linking CXX shared library ../../../lib/libMIRTKRegistration.so
[ 48%] Built target LibRegistration
Scanning dependencies of target atlases
[ 48%] Creating directories for 'atlases'
[ 48%] Performing download step (download, verify and extract) for 'atlases'
-- Downloading...
   dst='/usr/local/src/MIRTK/build/Packages/DrawEM/atlases/src/atlases-dhcp-structural-pipeline-v1.zip'
   timeout='none'
-- Using src='https://biomedic.doc.ic.ac.uk/brain-development/downloads/dHCP/atlases-dhcp-structural-pipeline-v1.zip'
-- [download 0% complete]
-- [download 1% complete]
...
-- [download 99% complete]
-- [download 100% complete]
-- verifying file...
       file='/usr/local/src/MIRTK/build/Packages/DrawEM/atlases/src/atlases-dhcp-structural-pipeline-v1.zip'
-- Downloading... done
-- extracting...
     src='/usr/local/src/MIRTK/build/Packages/DrawEM/atlases/src/atlases-dhcp-structural-pipeline-v1.zip'
     dst='/usr/local/src/MIRTK/build/Packages/DrawEM/atlases/src/atlases'
-- extracting... [tar xfz]
-- extracting... [analysis]
-- extracting... [rename]
-- extracting... [clean up]
-- extracting... done
[ 48%] No update step for 'atlases'
[ 50%] No patch step for 'atlases'
[ 50%] No configure step for 'atlases'
[ 50%] No build step for 'atlases'
[ 51%] No install step for 'atlases'
[ 51%] Completed 'atlases'
[ 51%] Built target atlases
Scanning dependencies of target atlases_move
[ 51%] Built target atlases_move
Scanning dependencies of target LibDrawEM
...

After make, /usr/local/src/MIRTK/build/Packages/DrawEM/atlases/src/atlases looks like this:

root@df6c1e51575b:~# ls /usr/local/src/MIRTK/build/Packages/DrawEM/atlases/src
atlases-build  atlases-dhcp-structural-pipeline-v1.zip  atlases-stamp

So the atlas downloaded, but it has not been unpacked. Perhaps cmake is expecting a .tar.gz rather than a zip?

When you run make install, it fails like this:

[ 48%] Built target LibRegistration
[ 51%] Built target atlases
Error renaming from "/usr/local/src/MIRTK/build/Packages/DrawEM/atlases/src/atlases" to "/usr/local/src/MIRTK/Packages/DrawEM/atlases": No such file or directory
Packages/DrawEM/CMakeFiles/atlases_move.dir/build.make:76: recipe for target 'Packages/DrawEM/CMakeFiles/atlases_move' failed
make[2]: *** [Packages/DrawEM/CMakeFiles/atlases_move] Error 1
CMakeFiles/Makefile2:1842: recipe for target 'Packages/DrawEM/CMakeFiles/atlases_move.dir/all' failed
make[1]: *** [Packages/DrawEM/CMakeFiles/atlases_move.dir/all] Error 2
Makefile:170: recipe for target 'all' failed
make: *** [all] Error 2

If I go in and unzip the atlases by hand:

root@df6c1e51575b:~# cd /usr/local/src/MIRTK/build/Packages/DrawEM/atlases/src
root@df6c1e51575b:/usr/local/src/MIRTK/build/Packages/DrawEM/atlases/src# unzip -qq atlases-dhcp-structural-pipeline-v1.zip 

make install now succeeds.