Dragging an event over the top boundary of a day on "Week View" crashes the plugin

[Italo-Vieira]

On "Day View" this is handled gracefully but on "Week View" crashes the plugin, the video below shows it better

issue-evidence.mov

[Italo-Vieira]

It seems the root cause is because in the AllDayCell (used in WeekView) no value is set for the "data" parameter of the useDroppable function.

makemd/src/core/react/components/SpaceView/Contexts/CalendarView/WeekView/AllDayCell.tsx

Lines 18 to 20 in 1929944

	const { setNodeRef } = useDroppable({
	id: "allday-" + props.date.toISOString(),
	});

So when the onDropOver listener is triggered, the data field is null, since there is no null check an exception is raised which breaks the plugin.

makemd/src/core/react/components/SpaceView/Frames/ViewNodes/FrameEditorInstance.tsx

Lines 59 to 71 in 1929944

	onDragOver: ({ active, over }) => {
	const overId = over?.data.current.node;
	if (over?.data.current.root == id) {
	if (overId)
	setHoverNode({
	id: over?.data.current.id,
	node: over?.data.current.node as string,
	direction: over?.data.current?.direction,
	});
	} else {
	setHoverNode(null);
	}
	},

makemd/src/core/react/components/Explorer/PropertiesView.tsx

Lines 261 to 265 in 1929944

	onDragOver({ active, over }) {
	const overId = over?.data.current.id;
	if (over?.data.current.type == "property")
	if (overId) setHoverNode(overId as string);

The DayView works because it set's up the all day cell in a different way and passes values on the data parameter

makemd/src/core/react/components/SpaceView/Contexts/CalendarView/DayView/DayView.tsx

Lines 385 to 388 in 1929944

	const { setNodeRef } = useDroppable({
	id: containerId,
	data: { type: "day-view", date },
	});