WebExport crashes on (skybox) files

[DevRuto]

https://i.imgur.com/6aYcS1W.png (thanks to Ocelot)
Occurs on attempting to export kz_unity_01 and kz_ziggurath_final

[DevRuto]

Unable to export kz_zxp_interstellar_v2, kz_htc_purgatory, and kz_blackness

[DaLLuZZ]

turning off --verbose option prevents it from crashes

I'm facing exactly the same problem when the program tries to export the vertigoblue skybox which is the standard csgo one

It seems that its name should contain "_hdr", so it should be vertigoblue_hdr instead
But this is what happens during surf_ameliorate export

[19/336] Exporting '/materials/skybox/vertigoblue_rt.vtf.json' ... Failed
[20/336] Exporting '/materials/skybox/vertigoblue_lf.vtf.json' ... Failed
[21/336] Exporting '/materials/skybox/vertigoblue_bk.vtf.json' ... Failed
[22/336] Exporting '/materials/skybox/vertigoblue_ft.vtf.json' ... Failed
[23/336] Exporting '/materials/skybox/vertigoblue_up.vtf.json' ... Failed
[24/336] Exporting '/materials/skybox/vertigoblue_dn.vtf.json' ... Failed

I decompiled surf_ameliorate using bspsrc. It turned out that the map itself uses skyname with "_hdr" postfix

"skyname" "vertigoblue_hdr"

Perhaps the program incorrectly reads the skyname from the .bsp file, so it looks like this issue is duplicate of #12

[DaLLuZZ]

There is a way to get rid of program crashes without removing the --verbose option from the program launch options

SourceUtils/SourceUtils.WebExport/Export.cs

Lines 233 to 250 in 0f15906

	catch ( WebException e )
	{
	++failed;
	if ( args.Verbose )
	{
	Console.ForegroundColor = ConsoleColor.DarkRed;
	Console.WriteLine("Failed");
	using ( var stream = e.Response.GetResponseStream() )
	{
	using ( var reader = new StreamReader( stream ) )
	{
	Console.WriteLine( reader.ReadToEnd() );
	}
	}
	}
	}

It is necessary to check e.Response for null in order to avoid crashing the program

catch ( WebException e )
{
    ++failed;

    if ( args.Verbose )
    {
        Console.ForegroundColor = ConsoleColor.DarkRed;
        Console.WriteLine("Failed");

        if ( e.Response != null)
        {
            using ( var stream = e.Response.GetResponseStream() )
            {
                using ( var reader = new StreamReader( stream ) )
                {
                    Console.WriteLine( reader.ReadToEnd() );
                }
            }
        }
        else
            Console.WriteLine("Null Response");
    }
}

But this will not solve the problem with the skybox itself, it will only save the program from crashing and make it possible to continue exporting without restarting. Judging by the behavior of the program during the export of the skybox, the problem is in some kind of infinite loop

Worth a look at this method

SourceUtils/SourceUtils.WebExport/Material.cs

Lines 294 to 345 in e64dd0b

	public static Material CreateSkyMaterial( ValveBspFile bsp, string skyName )
	{
	var postfixes = new[]
	{
	"rt", "lf", "bk", "ft", "up", "dn"
	};
	var names = new []
	{
	"PosX", "NegX", "PosY", "NegY", "PosZ", "NegZ"
	};
	var skyMaterial = new Material { Shader = "SourceUtils.Shaders.Sky" };
	skyMaterial.SetBoolean( "cullFace", false );
	var hdrCompressed = false;
	var aspect = 1f;
	for ( var face = 0; face < 6; ++face )
	{
	var matPath = $"materials/skybox/{skyName}{postfixes[face]}.vmt";
	var mat = Get( bsp, matPath );
	if ( mat == null ) continue;
	var texProp = mat.Properties.FirstOrDefault( x => x.Name == "hdrcompressedtexture")
	?? mat.Properties.First(x => x.Name == "basetexture");
	if ( face == 0 )
	{
	hdrCompressed = texProp.Name == "hdrcompressedtexture";
	var tex = Texture.Get( bsp, TextureController.GetTexturePath( (Url) texProp.Value ) );
	aspect = tex == null ? 1f : (float) tex.Width / tex.Height;
	}
	skyMaterial.SetTextureUrl($"face{names[face]}", (Url)texProp.Value);
	}
	if ( hdrCompressed )
	{
	skyMaterial.SetBoolean( "hdrCompressed", true );
	}
	if ( aspect != 1f )
	{
	skyMaterial.SetNumber( "aspect", aspect );
	}
	return skyMaterial;
	}